Fixed some spec files being ignored #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a certain point in my project,
npm test
started to ignore certain spec files. I don't know enough about npm as to know why this happened but I guess it has to do with how thepackage.json
file is read and how the command is executed (shell, env, user, …).A fresh
react-slingshot
checkout works fine.I fixed it for my project by passing the
src/**/*.spec.js
argument wrapped in double-quotes (see diff).For reference, my only spec files:
If I execute
mocha tools/testSetup.js src/**/*.spec.js
in zsh it works and runs all spec files. If I donpm test
(without this PR applied) it only runsContinueButtons.spec.js
. With this PR it runs them all.