Don't use no-unused-vars:0 and jsx-uses-vars:1 together #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to enable "jsx-uses-vars" when "no-unused-vars" is disabled. Linting for unused vars is useful so I've left no-unused-vars enabled from "eslint:recommended", however disabling "no-unused-vars" and removing "jsx-uses-vars" would be equally valid. "If you are not using JSX or if you do not use the no-unused-vars rule then you can disable this rule." ref: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-vars.md#when-not-to-use-it
|
I'm confused. You removed no-unused-vars, but left jsx-uses-vars enabled. Given the link you provided, it appears we should either have both enabled or both disabled. Am I missing something? |
|
I'm sorry, I should have mentioned that the "extends": "eslint:recommended" property enables "no-unused-vars": http://eslint.org/docs/rules/#variables so it's already enabled by default. |
|
Ah, great point. Thanks for the PR! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to enable "jsx-uses-vars" when "no-unused-vars" is disabled. Linting for unused vars is useful so I've left no-unused-vars enabled from "eslint:recommended", however disabling "no-unused-vars" and removing "jsx-uses-vars" would be equally valid.
"If you are not using JSX or if you do not use the no-unused-vars rule then you can disable this rule." ref: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-uses-vars.md#when-not-to-use-it