Throw error instances instead of strings and objects #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the exception property is replaced by the native cause property, the dataSet property is still available.
|
CI failed to install Firefox. :/ looks like the firefox download url used by the script is not valid anymore, returned a 404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46
created
DicomParserErrorto replace the{exception, dataSet}objectreplace thrown string by corresponding native errors (
Error,TypeErrorandRangeError) with appropriate messages.removed the scope from the error messages, the stack trace provide the same information in a more detailed way.
all test passes
fixed linting error on modified lines