version 1.1.6 didn't fix spacing issue

[pietrofxq]

Issue still happening for me on windows 10.

[momocow]

Also facing the same issue.

[pkucherov]

same problem

[andvarp]

Same issue.

[andvarp]

I solved this issue by deleting the tool and installing it again with another installation path that doesn't include spaces on it, like this:
C:\nvm

[coreybutler]

I'd be curious if #355 fixes the issue. I've tried a few different means of fixing this in the past, but I'd like to merge this PR if it resolves the issue for folks.

[s-h-a-d-o-w]

It seems like it fixes the issue for at least 2 people based on the reactions to my following comment: #41 (comment)

So I'd suggest people try out my fork (release is linked in that comment) and report back here, to (hopefully) get a larger sample size regarding people for whom the fix works. :)

[momocow]

@s-h-a-d-o-w There are several problems occured while using nvm v1.1.7 from your fork.

First of all, I tried to install the latest Nodejs, but tag v6.2.0 on npm/npm returns 404 because the official npm repository has moved. I manually downloaded npm from npm/cli and extracted it to <nvm_path>\v10.8.0\node_modules\npm. Then I tried to use it but failed with status 5.

I was thinking if it was the problem caused by failed npm installation (also my manual installation was in a wrong way). I tried to install node v6.14.3. The installation worked like a charm but I failed to use it again with status 5.

[s-h-a-d-o-w]

Well, I didn't change any code related to the npm repository, so yes - v10.8.0 doesn't work with my fork either. Because it probably also wouldn't with the original.

As for v6.14.3 - alright, I don't know about that one. I have a space in my nvm install path too but I just tried to install and use that version and it works for me... :/
It's interesting to note though that the exit status is 5 and not 1. I don't know nvm-windows well enough to know what that status means but I suppose Corey does...

[momocow]

@s-h-a-d-o-w I've installed the original nvm-windows and have uninstalled it before using your fork. Not sure if it is the issue that there are still files or directories that were not cleaned up.

I should try to make a clean install of your fork.

[momocow]

@s-h-a-d-o-w Your fork works! 😄 🎉

(Your tag is 1.1.7 however nvm version returns 1.1.6 😕 )

It was my bad that I did not run the terminal as the admin while using nvm use.
Therefore the modification to the symlink failed.

[coreybutler]

@s-h-a-d-o-w If you rebase your fork on the 1.1.7 tag (currently master), node 10.8.0+ should work. That issue has nothing to do with your fork.... but I fixed it last night in master.

[s-h-a-d-o-w]

Rebase done, updated the executables in release 1.1.7 of my fork. (So now even the nvm version information matches 😉 )

Can confirm that installing v10.8.0 works for me too now. 😄

[coreybutler]

#355 has been merged and appears to be working well. Expect it in the 1.1.8 release (available now in master).

[euroclydon37]

This is still affecting me in version 1.1.7.

[coreybutler]

@euroclydon37 - right, as I said, it'll land in 1.1.8. You can build from source if you need this now.