Skip to content

Conversation

@cgwalters
Copy link
Member

Closes: #5324

@cgwalters cgwalters requested a review from Copilot April 4, 2025 14:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

rust/src/compose.rs:264

  • [nitpick] The variant name 'OciOrRegistry' may be ambiguous regarding whether it covers both OCI and registry transports. Consider renaming it to something more descriptive, such as 'UnprivilegedContainer' or similar.
OciOrRegistry,

.github/workflows/ci.yaml:279

  • [nitpick] Ensure that 'test-oci.sh' provides adequate coverage for the unprivileged OCI/registry workflow and is maintained alongside changes to the transport handling.
sudo ./test-oci.sh

@cgwalters cgwalters marked this pull request as draft April 4, 2025 14:45
@cgwalters
Copy link
Member Author

Nah this doesn't handle uid/gid right, it's going to require more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rechunker: Support running from buildah container

1 participant