Skip to content

Conversation

@AdrianLThomas
Copy link
Contributor

@AdrianLThomas AdrianLThomas commented Oct 10, 2024

Summary

Additional test coverage for assigning concepts to Assets and Entries.

Covers 3 main areas:

  1. Creating an {entry/asset} with a new concept assigned
  2. Updating an {entry/asset} with a new concept assigned
  3. Deleting an assigned concept from an {entry/asset}

Description

As per summary, but also migrated entry-integration.js to Typescript.

Motivation and Context

The implementation was already functionally in place to assign a Concept to a Taxonomy, therefore this PR is just for some additional test coverage.

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

file: '<svg xmlns="http://www.w3.org/2000/svg"><path fill="red" d="M50 50h150v50H50z"/></svg>',
},
},
description: {},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description is mandatory on the type (where the definition was missing previously).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to TS

@AdrianLThomas AdrianLThomas marked this pull request as ready for review October 10, 2024 07:20
@AdrianLThomas AdrianLThomas requested a review from a team as a code owner October 10, 2024 07:20
@AdrianLThomas AdrianLThomas enabled auto-merge (squash) October 10, 2024 07:34
@AdrianLThomas AdrianLThomas merged commit e17b84d into master Oct 11, 2024
3 checks passed
@AdrianLThomas AdrianLThomas deleted the GROOT-1483/integration-tests-taxonomy-for-assets branch October 11, 2024 09:42
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.36.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants