fix: align types to API and normalize naming #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
force-pushed
the
fix/types
branch
from
86f282a to
c53218b
Compare
|
🎉 This PR is included in version 11.35.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rewriting and typing tests to vitest, I found out that some types are not reflecting the actual Contentful API structure.
#2328
AccessTokenProp->AccessTokenPropsPersonalAccessTokenProp->OrganizationPropsOrganizationProp->OrganizationPropsEntityMetaSysPropscontentType(As its entry only)status?(Some entity have it)EntryMetaSysPropscontentType(As assets & co don't have this prop -> https://www.contentful.com/developers/docs/references/content-management-api/#/reference/assets/asset)ReleaseActionSysPropsupdatedBy(https://www.contentful.com/developers/docs/references/content-management-api/#/reference/releases/releases)