Use modelstore as tmpdir for hfcli

[engelmi]

Relates to: #1778

Instead of creating a temporary directory in the default location, lets use the modelstore directory for the hfcli files until these are moved to a snapshot.
The created temporary directory will always been cleaned up.

Summary by Sourcery

Enhancements:

• Create hfcli temp directories under model_store.base_path with prefix "tmp_hfcli_" instead of using the system default temp location

[sourcery-ai]

Reviewer's Guide

This PR updates the HF style repository base logic to create CLI download temporary directories under the configured model store path (with a consistent prefix), ensuring that all transient files reside within the model store and are cleaned up automatically.

Class diagram for updated temporary directory creation in HFStyleRepoBase

classDiagram
    class HFStyleRepoBase {
        model_store: ModelStore
        pull(args)
        get_cli_download_args(tempdir, model)
    }
    class ModelStore {
        base_path: str
    }
    HFStyleRepoBase --> ModelStore : uses
    HFStyleRepoBase : +pull(args)
    HFStyleRepoBase : +get_cli_download_args(tempdir, model)
    HFStyleRepoBase : - uses tempfile.TemporaryDirectory(prefix, dir)
    note for HFStyleRepoBase "TemporaryDirectory now uses dir=self.model_store.base_path and prefix='tmp_hfcli_'"

Loading

File-Level Changes

Change	Details	Files
Use model store directory for hfcli temporary directories	Added prefix "tmp_hfcli_" to TemporaryDirectory Set dir parameter to self.model_store.base_path	ramalama/hf_style_repo_base.py

Possibly linked issues

• Models downloaded to /tmp instead of $HOME/.local/share/ramalama #1778: PR changes huggingface-cli temporary download directory to the ramalama model store, resolving the 'no space left on device' error in /tmp.
• Models downloaded to /tmp instead of $HOME/.local/share/ramalama #1778: PR modifies temp directory for hfcli downloads to model store, fixing --store flag failure.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @engelmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the temporary file management for Hugging Face CLI operations, ensuring that temporary download directories are now created in a more organized and specific location within the modelstore's base path. This change aims to improve the logical grouping of related files while maintaining the automatic cleanup of these temporary resources.

Highlights

• Temporary Directory Location: I've updated the pull method in ramalama/hf_style_repo_base.py to create temporary directories for Hugging Face CLI downloads within the self.model_store.base_path instead of the system's default temporary location.
• Temporary Directory Naming: I've added a prefix="tmp_hfcli_" to the temporary directories created, making them easily identifiable as related to hfcli operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @engelmi - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

The pull request updates the temporary directory creation for hfcli to use the model store's path. This is a good optimization for file moves. My review includes one high-severity comment to prevent a potential crash in the fallback logic by ensuring the target directory exists before use, and also suggests a cleaner implementation for better file organization.

[rhatdan]

LGTM