Fix assembling URLs for big models

[engelmi]

Previously, the loop was missing the first file of a big model and using the same name for all models. This has been fixed in this PR.

For example, previously running

ramalama pull https://huggingface.co/unsloth/Qwen3-Coder-480B-A35B-Instruct-GGUF/resolve/main/Q3_K_M/Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00001-of-00005.gguf`

would result in the following files to be downloaded (missing the 00001):

https://huggingface.co/unsloth/Qwen3-Coder-480B-A35B-Instruct-GGUF/resolve/main/Q3_K_M/Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00002-of-00005.gguf
https://huggingface.co/unsloth/Qwen3-Coder-480B-A35B-Instruct-GGUF/resolve/main/Q3_K_M/Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00003-of-00005.gguf
https://huggingface.co/unsloth/Qwen3-Coder-480B-A35B-Instruct-GGUF/resolve/main/Q3_K_M/Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00004-of-00005.gguf
https://huggingface.co/unsloth/Qwen3-Coder-480B-A35B-Instruct-GGUF/resolve/main/Q3_K_M/Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00005-of-00005.gguf

And each file would have the same name of Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00001-of-00005.gguf, causing previously downloaded files to be overwritten.

With this fix, it correctly downloads the following files with their respective names:

Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00001-of-00005.gguf
Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00002-of-00005.gguf
Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00003-of-00005.gguf
Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00004-of-00005.gguf
Qwen3-Coder-480B-A35B-Instruct-Q3_K_M-00005-of-00005.gguf

Summary by Sourcery

Correctly assemble URLs and filenames for split model files to include the first part and prevent overwriting by generating unique names for each part

Bug Fixes:

• Include the first part when assembling URLs for split models and prevent filename collisions by generating unique filenames for each part

Enhancements:

• Extract split model file list generation into a dedicated private _assemble_split_file_list method

[sourcery-ai]

Reviewer's Guide

Encapsulate split-model file assembly into a dedicated helper and correct the file-part enumeration and naming to include the first part and avoid overwrites.

Class diagram for updated split-model file assembly

classDiagram
    class ModelHandler {
        +_assemble_split_file_list(snapshot_hash: str) list[SnapshotFile]
        +pull(_)
    }
    class SnapshotFile {
        +url: str
        +header: dict
        +hash: str
        +type: SnapshotFileType
        +name: str
        +should_show_progress: bool
        +required: bool
    }
    ModelHandler --> SnapshotFile : creates

Loading

File-Level Changes

Change	Details	Files
Refactor split-model URL assembly and fix indexing/naming	Extracted new private method _assemble_split_file_list to build split-file list Removed outdated in-line split loop in pull() and replaced it with a call to the new helper Changed loop to iterate from part 1 through total_parts with zero-padded indices and use file-specific names	ramalama/url.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @engelmi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves critical issues in how the application handles the downloading of large, multi-part models. By refactoring the URL assembly and file naming conventions, it ensures that all model segments are correctly retrieved and stored, preventing previously reported problems of missing files and data corruption due to overwrites.

Highlights

• Corrected URL Assembly for Split Models: The logic for generating URLs and filenames for multi-part models (e.g., .gguf files split into several parts) has been refactored. This change ensures that all necessary parts are correctly identified and included, starting from the first part (e.g., 00001-of-00005.gguf), and that each part is assigned its unique filename to prevent overwrites during the download process.
• New Helper Method for Modularity: Introduced a new private helper method, _assemble_split_file_list, within ramalama/url.py. This method encapsulates the complex logic for generating the list of SnapshotFile objects for split models, improving code modularity, readability, and maintainability by centralizing the file assembly process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @engelmi - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request fixes an issue with downloading large, split models by ensuring all files are downloaded with the correct names. The logic has been refactored into a new private method _assemble_split_file_list, improving code organization. My review includes one suggestion to improve efficiency by avoiding calling _assemble_split_file_list when it's not needed.

[rhatdan]

Fixes: #1755