-
Notifications
You must be signed in to change notification settings - Fork 235
Fixes docsite page linking #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ian Eaves <[email protected]>
Reviewer's GuideThis PR refines docsite generation and linking by enhancing title extraction for specific manpages, improving markdown conversion with history footers, standardizing internal ‘See Also’ links to absolute paths, adding a Makefile target to clean generated MDX files, and updating frontmatter for configuration pages. Class diagram for updated docsite manpage conversion logicclassDiagram
class convert_manpages {
+extract_title_and_description(content, filename)
+convert_markdown_to_mdx(content, filename)
+convert_link(match)
}
extract_title_and_description : - Handles .5.md files with custom titles
extract_title_and_description : - Fallback for other .5.md files
convert_markdown_to_mdx : - Removes HISTORY TOC links
convert_markdown_to_mdx : - Appends history as footer
convert_link : - Standardizes See Also links to absolute paths
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ieaves, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on improving the user experience and maintainability of the documentation site. It addresses various linking inconsistencies, refines the processing of auto-generated documentation content, and enhances the build system for better management of documentation files.
Highlights
- Documentation Linking Improvements: Standardized internal links within the documentation, especially for 'See Also' sections in command manpages, to point to the main command category index (
/docs/commands/ramalama/
) rather than specificramalama
files. This affects numerous command pages likebench
,chat
,convert
,run
,serve
, and others, as well as platform guides. - Auto-generated Content Refinements: Enhanced the
convert_manpages.py
script to provide more descriptive titles for specific configuration files (ramalama.conf.5.md
andramalama-oci.5.md
) and to correctly handle theHISTORY
section by moving its content to a page footer and removing its entry from the Table of Contents. - Docsite Build Process Enhancement: Added a new
clean-generated
target to theMakefile
to facilitate the removal of auto-generated MDX files, improving the documentation build and cleanup workflow. - Navigation Correction: Updated the 'Getting Started' link in the Docusaurus navbar to directly point to the
installation
page, providing a more direct entry point for new users.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ieaves - I've reviewed your changes - here's some feedback:
- Consider moving the special-case .5.md title mappings into a centralized dictionary or config to simplify future additions instead of hard-coding if/else branches.
- The hard-coded '/docs/commands/ramalama/' path in convert_link is duplicated in multiple places — extracting it as a constant or config value would reduce duplication and risk of typos.
- Verify that changing the nav entry from '/docs/getting-started' to '/docs/getting-started/installation' won’t confuse users expecting a standalone Getting Started overview page.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the special-case .5.md title mappings into a centralized dictionary or config to simplify future additions instead of hard-coding if/else branches.
- The hard-coded '/docs/commands/ramalama/' path in convert_link is duplicated in multiple places — extracting it as a constant or config value would reduce duplication and risk of typos.
- Verify that changing the nav entry from '/docs/getting-started' to '/docs/getting-started/installation' won’t confuse users expecting a standalone Getting Started overview page.
## Individual Comments
### Comment 1
<location> `docsite/convert_manpages.py:145` </location>
<code_context>
if history_match:
history_text = history_match.group(1).strip()
content = re.sub(history_pattern, '', content, flags=re.DOTALL)
+ # Remove TOC links to HISTORY since it becomes a footer
+ content = re.sub(r'\s*- \[HISTORY\]\(#history\)\n?', '', content)
# Add history as footer
content += f"\n\n---\n\n*{history_text}*"
</code_context>
<issue_to_address>
The regex for removing HISTORY TOC links may miss variants.
The regex should account for variations in spacing, casing, and list markers to ensure all HISTORY TOC links are removed.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
# Remove TOC links to HISTORY since it becomes a footer
content = re.sub(r'\s*- \[HISTORY\]\(#history\)\n?', '', content)
=======
# Remove TOC links to HISTORY since it becomes a footer
content = re.sub(
r'^[ \t]*[-*][ \t]*\[[ \t]*history[ \t]*\][ \t]*\([ \t]*#history[ \t]*\)[ \t]*(?:\r?\n)?',
'',
content,
flags=re.IGNORECASE | re.MULTILINE
)
>>>>>>> REPLACE
</suggested_fix>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses documentation linking issues and improves the generation process. The changes are clear and directly support the goal of a more robust and user-friendly documentation site.
LGTM |
Summary by Sourcery
Fix docsite linking issues and improve manpage-to-mdx conversion
Bug Fixes:
Enhancements:
Documentation: