build_rag.sh: install cmake

[mikebonnet]

cmake is required to build sentencepiece.

Summary by Sourcery

Build:

• Include cmake in the packages installed via dnf and apt in build_rag.sh

[sourcery-ai]

Reviewer's Guide

This PR updates the build_rag.sh script to install cmake as part of the build dependencies, ensuring sentencepiece can be built successfully.

File-Level Changes

Change	Details	Files
Include cmake in package installation lists	Added "cmake" to the DNF package array Added "cmake" to the alternative package array	container-images/scripts/build_rag.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @mikebonnet, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical build dependency by integrating cmake into the build_rag.sh script. The change ensures that the necessary cmake tool is available during the build process, specifically to facilitate the successful compilation of sentencepiece, a component vital for the RAG (Retrieval Augmented Generation) system.

Highlights

• Build Dependency Resolution: Added cmake to the list of required packages within the build_rag.sh script. This ensures cmake is installed as a prerequisite for building sentencepiece, which is necessary for the RAG setup.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @mikebonnet - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request correctly adds cmake as a build dependency. My review includes a suggestion to refactor the package installation logic to reduce code duplication for both cmake and the pre-existing gcc package, which will improve the script's maintainability.

[bmahabirbu]

Looks good! Was this an issue for local builds too btw? I didnt come across it when testing

[mikebonnet]

It's only an issue for the intel-gpu-rag build because the intel-gpu build is multi-stage and the final image doesn't have the dev tools installed by build_llama_and_whisper.sh, which is run in the builder image.

[bmahabirbu]

Makes sense! Thanks for the context! Once the intel build test passes then we'll be good to go

[mikebonnet]

The intel-gpu-rag build succeeded, even though the pipeline failed on an unrelated infra issue (failed image pull): https://konflux-ui.apps.kflux-prd-rh03.nnv1.p1.openshiftapps.com/ns/ramalama-tenant/applications/ramalama/taskruns/intel-gpu-rag-on-pull-request-lcdhv-build-images/logs

So it looks like this fix is good.