Add support for Intel Iris Xe Graphics (46AA, 46A6, 46A8)

[tonyjames]

This commit adds the Intel Iris Xe Graphics (46AA, 46A6, 46A8) chips to the check_intel function so that the ramalama/intel-gpu image is used. Without this the standard ramalama/ramalama image is used with very poor performance.

Summary by Sourcery

Enhancements:

• Add Intel Iris Xe Graphics device IDs (0x46aa, 0x46a6, 0x46a8) to the check_intel function

[sourcery-ai]

Reviewer's Guide

The PR extends the GPU detection routine to recognize Intel Iris Xe variants so the optimized ramalama/intel-gpu container is used instead of the default, improving performance.

Class diagram for updated GPU detection in check_intel

classDiagram
    class check_intel {
        +Literal["intel"] | None check_intel()
        intel_gpus: tuple[bytes]
    }
    %% Added GPU IDs
    check_intel : +b"0x46aa"
    check_intel : +b"0x46a6"
    check_intel : +b"0x46a8"

Loading

File-Level Changes

Change	Details	Files
Include Intel Iris Xe GPU device IDs in the check_intel recognition logic	Add device ID 0x46aa Add device ID 0x46a6 Add device ID 0x46a8	ramalama/common.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @tonyjames, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a performance issue for users with certain Intel Iris Xe Graphics cards by extending the system's hardware detection capabilities. By recognizing these specific GPU device IDs, the application can now correctly select and use an optimized Docker image, thereby significantly improving performance for affected users.

Highlights

• Intel GPU Support: Added support for specific Intel Iris Xe Graphics device IDs (46AA, 46A6, 46A8) to the check_intel function. This ensures that systems with these GPUs correctly utilize the ramalama/intel-gpu Docker image, preventing the use of the default ramalama/ramalama image which leads to poor performance.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @tonyjames - I've reviewed your changes - here's some feedback:

• Consider verifying the PCI vendor ID (0x8086) before matching device IDs to ensure only real Intel GPUs are detected.
• Add a code comment or reference to the official Intel GPU ID registry for the new 0x46AA/46A6/46A8 device IDs to aid future maintainability.
• You could extract the intel_gpus tuple into a named constant or set at the top of the file for clearer grouping and faster lookups.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider verifying the PCI vendor ID (0x8086) before matching device IDs to ensure only real Intel GPUs are detected.
- Add a code comment or reference to the official Intel GPU ID registry for the new 0x46AA/46A6/46A8 device IDs to aid future maintainability.
- You could extract the intel_gpus tuple into a named constant or set at the top of the file for clearer grouping and faster lookups.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request adds support for Intel Iris Xe Graphics device IDs (0x46AA, 0x46A6, 0x46A8) to the check_intel function. A suggestion was made to sort the intel_gpus tuple alphabetically to improve maintainability.

[gemini-code-assist]

The intel_gpus tuple is not sorted alphabetically. For improved readability and maintainability, please sort the entries in ascending order. This makes it easier to find existing device IDs and add new ones without introducing duplicates.

Suggested change

	b"0x46aa",
	b"0x46a6",
	b"0x46a8",
	b"0x46a6",
	b"0x46a8",
	b"0x46aa",

[rhatdan]

LGTM