Minor fixes to rpm builds by packit and spec file. #1704

smooge · 2025-07-16T13:13:08Z

This removes epel9 from packit rules as epel9 does not currently build without many additional packages added to the distro.
This fixes a breakage in epel10 by adding mailcap as a buildrequires.

Summary by Sourcery

Remove the unsupported epel9 build target in packit config, switch to epel10.0, add mailcap to spec BuildRequires to fix epel10 breakage, and bump the Obsoletes version.

Bug Fixes:

Add mailcap to spec file BuildRequires to resolve build failures on epel10

Enhancements:

Replace epel9 with epel10.0 in packit configuration
Update spec file Obsoletes entry to < 0.11.0-1

* This removes epel9 from packit rules as epel9 does not currently build without many additional packages added to the distro. * This fixes a breakage in epel10 by adding mailcap as a buildrequires. Signed-off-by: Stephen Smoogen <[email protected]>

sourcery-ai · 2025-07-16T13:13:14Z

Reviewer's Guide

Streamlined RPM build configurations by removing EPEL 9 in favor of EPEL 10.0 in packit jobs, and resolved a build breakage in EPEL 10 by adding mailcap and updating the Obsoletes version in the spec file.

Class diagram for updated BuildRequires in the spec file

classDiagram
    class SpecFile {
        +make
        +python3-devel
        +podman
        +python3-pytest
        +mailcap
        +Obsoletes: python3-ramalama < 0.11.0-1
    }

File-Level Changes

Change	Details	Files
Standardize dist-git branches to epel10.0 and remove epel9	Replace epel9 with epel10.0 in packit job triggers Ensure both koji_build and the secondary job reference epel10.0 only	`.packit.yaml`
Fix spec build requirements and update obsolete version	Add mailcap as a BuildRequires to satisfy EPEL 10 dependencies Bump Obsoletes threshold from <0.10.1-2 to <0.11.0-1	`rpm/ramalama.spec`

Possibly linked issues

Configure Renovate #1: The PR removes epel9 from packit rules, directly addressing the propose downstream failure for epel9.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist

Summary of Changes

Hello @smooge, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the reliability and stability of RPM package builds for the ramalama project. It addresses specific build failures by adjusting the packit configuration to refine target distributions and updates the RPM spec file to resolve missing build dependencies and update versioning.

Highlights

Packit Configuration Adjustment: Updated .packit.yaml to refine target distribution branches for koji_build and bodhi_update jobs. Specifically, epel9 was removed from the dist_git_branches list and replaced with epel10.0, addressing issues with epel9 builds and clarifying the EPEL 10 target.
RPM Spec File Enhancements: Modified rpm/ramalama.spec to include mailcap in BuildRequires, which resolves a reported build breakage in epel10. Additionally, the Obsoletes version for python3-ramalama was updated to reflect a newer baseline.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

sourcery-ai

Hey @smooge - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist

Code Review

This pull request updates the RPM packaging configuration. It adds a missing build dependency for EPEL 10, bumps the Obsoletes version tag, and updates the packit build targets to remove epel9. The changes to the spec file look correct. However, the update to the packit configuration introduces a potentially invalid and redundant build target (epel10.0), which could cause the build pipeline to fail. I've left comments with details on this.

gemini-code-assist · 2025-07-16T13:14:38Z

.packit.yaml

@@ -79,7 +79,7 @@ jobs:
    dist_git_branches: &fedora_targets
      - fedora-all
      - epel10
-      - epel9
+      - epel10.0


The dist_git_branches list already contains epel10 on the line above. Adding epel10.0 here seems redundant. Furthermore, epel10.0 is not a standard dist-git branch name for EPEL, which is likely to cause this koji_build job to fail. The standard branch name is epel10.

If the intention was just to remove epel9 support, this line should be removed entirely as epel10 is already present.

gemini-code-assist · 2025-07-16T13:14:38Z

.packit.yaml

@@ -92,4 +92,4 @@
    dist_git_branches:
      - fedora-branched # rawhide updates are created automatically
      - epel10
-      - epel9
+      - epel10.0


Similar to the koji_build job configuration, the dist_git_branches list for this propose_downstream job already contains epel10. Adding epel10.0 seems redundant and is likely to cause job failures because epel10.0 is not a standard dist-git branch name. If epel10 is the correct target, this line can be removed.

rhatdan · 2025-07-16T13:32:21Z

LGTM

bmahabirbu · 2025-07-16T13:33:06Z

LGTM too!

* This removes epel9 from packit rules as epel9 does not currently build without many additional packages added to the distro. * This fixes a breakage in epel10 by adding mailcap as a buildrequires. Signed-off-by: Stephen Smoogen <[email protected]> Co-authored-by: Stephen Smoogen <[email protected]>

smooge requested review from rhatdan, ericcurtin, bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver and engelmi as code owners July 16, 2025 13:13

gemini-code-assist bot reviewed Jul 16, 2025

View reviewed changes

sourcery-ai bot approved these changes Jul 16, 2025

View reviewed changes

gemini-code-assist bot reviewed Jul 16, 2025

View reviewed changes

bmahabirbu approved these changes Jul 16, 2025

View reviewed changes

smooge merged commit 683b8fb into containers:main Jul 16, 2025
16 of 38 checks passed

bmahabirbu mentioned this pull request Jul 16, 2025

konflux: build cuda on arm64, and simplify testing #1687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Minor fixes to rpm builds by packit and spec file. #1704

Minor fixes to rpm builds by packit and spec file. #1704

Uh oh!

smooge commented Jul 16, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jul 16, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

sourcery-ai bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

gemini-code-assist bot Jul 16, 2025

Uh oh!

rhatdan commented Jul 16, 2025

Uh oh!

bmahabirbu commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

Minor fixes to rpm builds by packit and spec file. #1704

Minor fixes to rpm builds by packit and spec file. #1704

Uh oh!

Conversation

smooge commented Jul 16, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for updated BuildRequires in the spec file

File-Level Changes

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Jul 16, 2025

Uh oh!

bmahabirbu commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

smooge commented Jul 16, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jul 16, 2025 •

edited

Loading