musa: upgrade musa sdk to rc4.2.0 #1697

yeahdongcn · 2025-07-15T10:47:03Z

This will require syncing with the latest changes from llama.cpp once ggml-org/llama.cpp#14498 is merged.

Testing Done

IMAGE=musa make build with manually merging musa: upgrade musa sdk to rc4.2.0 ggml-org/llama.cpp#14498

Summary by Sourcery

Build:

Bump MUSA SDK version in Containerfile from rc4.0.1 to 4.2.0

Summary by Sourcery

Update Containerfile to use MUSA SDK rc4.2.0 and adjust base image tags

Build:

Bump MUSA SDK version from rc4.0.1 to rc4.2.0 in Containerfile
Update builder and runtime base images to use -devel-ubuntu${UBUNTU_VERSION}-amd64 and -runtime-ubuntu${UBUNTU_VERSION}-amd64 tags

sourcery-ai · 2025-07-15T10:47:09Z

Reviewer's Guide

This PR upgrades the MUSA SDK version in the Containerfile to rc4.2.0 and updates base image tags to the new naming convention by removing the 'mudnn' qualifier and appending the 'amd64' suffix.

File-Level Changes

Change	Details	Files
Upgrade MUSA SDK version	Bump ARG VERSION from rc4.0.1 to rc4.2.0	`container-images/musa/Containerfile`
Align base image tags with new naming convention	Remove 'mudnn' qualifier from devel and runtime image tags Append '-amd64' suffix to both devel and runtime tags	`container-images/musa/Containerfile`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist

Summary of Changes

Hello @yeahdongcn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the MUSA SDK version within the Containerfile used for building the MUSA container image. This change ensures that the container image is built against the latest specified stable version of the MUSA SDK, incorporating any new features, improvements, or bug fixes that come with the updated release.

Highlights

MUSA SDK Version Upgrade: The MUSA SDK version used in the Containerfile has been updated from rc4.0.1 to 4.2.0.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request upgrades the MUSA SDK version from a release candidate rc4.0.1 to the stable version 4.2.0 in the MUSA Containerfile. The change is straightforward.

Signed-off-by: Xiaodong Ye <[email protected]>

rhatdan · 2025-07-16T16:00:58Z

Why is this a draft?

yeahdongcn · 2025-07-16T23:45:19Z

Why is this a draft?

We're in the process of upgrading the MUSA SDK version across several repositories. I may need a bit more time to test everything before requesting your review.

Signed-off-by: Xiaodong Ye <[email protected]>

sourcery-ai

Hey @yeahdongcn - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

rhatdan · 2025-07-24T10:44:24Z

LGTM

mikebonnet · 2025-07-24T19:00:51Z

@yeahdongcn The build of https://github.com/ggerganov/whisper.cpp from d682e150908e10caa4c15883c633d7902d385237 is failing. Has this been tested with the new muda images?:

[ 32%] Building CXX object ggml/src/ggml-musa/CMakeFiles/ggml-musa.dir/__/ggml-cuda/cross-entropy-loss.cu.o
In file included from /src/ramalama/whisper.cpp/ggml/src/ggml-cuda/argsort.cu:1:
In file included from /src/ramalama/whisper.cpp/ggml/src/ggml-cuda/argsort.cuh:1:
/src/ramalama/whisper.cpp/ggml/src/ggml-cuda/common.cuh:97:16: error: use of undeclared identifier 'mublasStatus_to_string'; did you mean 'ggml_status_to_string'?
        return cublasGetStatusString(err);
               ^~~~~~~~~~~~~~~~~~~~~
               ggml_status_to_string
/src/ramalama/whisper.cpp/ggml/src/ggml-cuda/vendors/musa.h:31:31: note: expanded from macro 'cublasGetStatusString'
#define cublasGetStatusString mublasStatus_to_string
                              ^
/src/ramalama/whisper.cpp/ggml/src/../include/ggml.h:328:27: note: 'ggml_status_to_string' declared here
    GGML_API const char * ggml_status_to_string(enum ggml_status status);
                          ^
In file included from /src/ramalama/whisper.cpp/ggml/src/ggml-cuda/argsort.cu:1:
In file included from /src/ramalama/whisper.cpp/ggml/src/ggml-cuda/argsort.cuh:1:
/src/ramalama/whisper.cpp/ggml/src/ggml-cuda/common.cuh:97:38: error: cannot initialize a parameter of type 'enum ggml_status' with an lvalue of type 'const mublasStatus_t'
        return cublasGetStatusString(err);
                                     ^~~
/src/ramalama/whisper.cpp/ggml/src/../include/ggml.h:328:66: note: passing argument to parameter 'status' here
    GGML_API const char * ggml_status_to_string(enum ggml_status status);
                                                                 ^

Updating the musa images to rc4.2.0 requires a newer version of llama.cpp, and broke the whisper.cpp build. For more info see: #1697 Signed-off-by: Mike Bonnet <[email protected]>

yeahdongcn · 2025-07-25T00:59:27Z

@yeahdongcn The build of https://github.com/ggerganov/whisper.cpp from d682e150908e10caa4c15883c633d7902d385237 is failing. Has this been tested with the new musa images?:

Sorry for the inconvenience. I’ve tested the build locally by merging llama.cpp and whisper.cpp (as mentioned in the PR description). However, I wasn't familiar with your sync strategy for llama.cpp, so I only documented it in the PR, which turns out wasn’t sufficient. I saw your changes disabling the whisper.cpp musa build in ramalama — I’ll re-enable it once everything is properly synced and ready.

MasterYang7 · 2025-07-30T06:24:50Z

在官网无法找到musa 4.2.0的相关驱动

yeahdongcn · 2025-07-30T06:46:48Z

在官网无法找到musa 4.2.0的相关驱动

It is scheduled to be available within the week.

Updating the musa images to rc4.2.0 requires a newer version of llama.cpp, and broke the whisper.cpp build. For more info see: containers#1697 Signed-off-by: Mike Bonnet <[email protected]>

gemini-code-assist bot reviewed Jul 15, 2025

View reviewed changes

musa: upgrade musa sdk to 4.2.0

56caa32

Signed-off-by: Xiaodong Ye <[email protected]>

yeahdongcn force-pushed the xd/musa_sdk_upgrade branch from 42dd0ed to 56caa32 Compare July 15, 2025 10:50

musa: restore rc in docker image tag

3e68dc9

Signed-off-by: Xiaodong Ye <[email protected]>

yeahdongcn changed the title ~~musa: upgrade musa sdk to 4.2.0~~ musa: upgrade musa sdk to rc4.2.0 Jul 24, 2025

yeahdongcn marked this pull request as ready for review July 24, 2025 02:03

yeahdongcn requested review from rhatdan, ericcurtin, bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver and engelmi as code owners July 24, 2025 02:03

sourcery-ai bot approved these changes Jul 24, 2025

View reviewed changes

rhatdan merged commit 61e7360 into containers:main Jul 24, 2025
14 of 18 checks passed

mikebonnet mentioned this pull request Jul 24, 2025

musa: disable build of whisper.cpp, and update llama.cpp #1745

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

musa: upgrade musa sdk to rc4.2.0 #1697

musa: upgrade musa sdk to rc4.2.0 #1697

Uh oh!

yeahdongcn commented Jul 15, 2025 •

edited

Loading

Uh oh!

sourcery-ai bot commented Jul 15, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

rhatdan commented Jul 16, 2025

Uh oh!

yeahdongcn commented Jul 16, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

rhatdan commented Jul 24, 2025

Uh oh!

Uh oh!

mikebonnet commented Jul 24, 2025

Uh oh!

yeahdongcn commented Jul 25, 2025

Uh oh!

MasterYang7 commented Jul 30, 2025

Uh oh!

yeahdongcn commented Jul 30, 2025

Uh oh!

Uh oh!

musa: upgrade musa sdk to rc4.2.0 #1697

musa: upgrade musa sdk to rc4.2.0 #1697

Uh oh!

Conversation

yeahdongcn commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Done

Summary by Sourcery

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

rhatdan commented Jul 16, 2025

Uh oh!

yeahdongcn commented Jul 16, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Jul 24, 2025

Uh oh!

Uh oh!

mikebonnet commented Jul 24, 2025

Uh oh!

yeahdongcn commented Jul 25, 2025

Uh oh!

MasterYang7 commented Jul 30, 2025

Uh oh!

yeahdongcn commented Jul 30, 2025

Uh oh!

Uh oh!

yeahdongcn commented Jul 15, 2025 •

edited

Loading

sourcery-ai bot commented Jul 15, 2025 •

edited

Loading