Add gemma aliases #1624
Add gemma aliases #1624
Conversation
The ollama variants are incompatible Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
requested review from
rhatdan,
bmahabirbu,
maxamillion,
swarajpande5,
jhjaggars,
cgruver and
engelmi
as code owners
Reviewer's GuideAdds new gemma3n shortname aliases for E4B and E2B quantized variants by updating the shortnames.conf configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
- Consider alphabetizing the new
gemma3naliases to keepshortnames.confsorted and maintain readability. - You have both
gemma3n:e4bandgemma3n:e4b-it-q8_0pointing to the same URI—either consolidate them or clarify their distinct use cases. - Use consistent casing for
e4b/e2bin both the alias keys and the file paths to avoid any potential confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider alphabetizing the new `gemma3n` aliases to keep `shortnames.conf` sorted and maintain readability.
- You have both `gemma3n:e4b` and `gemma3n:e4b-it-q8_0` pointing to the same URI—either consolidate them or clarify their distinct use cases.
- Use consistent casing for `e4b`/`e2b` in both the alias keys and the file paths to avoid any potential confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces new shortname aliases for different variants of the gemma3n model, specifying different quantization levels and formats. This allows users to easily select and use specific versions of the model by using a shortname.
Highlights
- New Aliases: Added several new aliases for the
gemma3nmodel with different quantization levels (e4b, e2b) and formats (q8_0, f16). - Gemma3n Variants: The new aliases point to specific GGUF files for different variants of the
gemma3nmodel, hosted on Hugging Face.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| "gemma3n" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-Q8_0.gguf" | ||
| "gemma3n:e4b" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-Q8_0.gguf" | ||
| "gemma3n:e4b-it-q8_0" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-Q8_0.gguf" | ||
| "gemma3n:e4b-it-f16" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-f16.gguf" | ||
| "gemma3n:e2b" = "hf://ggml-org/gemma-3n-E2B-it-GGUF/gemma-3n-E2B-it-Q8_0.gguf" | ||
| "gemma3n:e2b-it-q8_0" = "hf://ggml-org/gemma-3n-E2B-it-GGUF/gemma-3n-E2B-it-Q8_0.gguf" | ||
| "gemma3n:e2b-it-f16" = "hf://ggml-org/gemma-3n-E2B-it-GGUF/gemma-3n-E2B-it-f16.gguf" |
There was a problem hiding this comment.
The base gemma3n alias points to the E4B variant. It might be clearer to explicitly define it as gemma3n:e4b to avoid ambiguity.
"gemma3n:e4b" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-Q8_0.gguf"
"gemma3n:e4b-it-q8_0" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-Q8_0.gguf"
"gemma3n:e4b-it-f16" = "hf://ggml-org/gemma-3n-E4B-it-GGUF/gemma-3n-E4B-it-f16.gguf"
"gemma3n:e2b" = "hf://ggml-org/gemma-3n-E2B-it-GGUF/gemma-3n-E2B-it-Q8_0.gguf"
"gemma3n:e2b-it-q8_0" = "hf://ggml-org/gemma-3n-E2B-it-GGUF/gemma-3n-E2B-it-Q8_0.gguf"
"gemma3n:e2b-it-f16" = "hf://ggml-org/gemma-3n-E2B-it-GGUF/gemma-3n-E2B-it-f16.gguf"
There was a problem hiding this comment.
This is deliberate "latest" == "e4b"
|
LGTM |
The ollama variants are incompatible
Summary by Sourcery
New Features: