Want to pick up support for gemma3n #1623

ericcurtin · 2025-06-27T14:07:19Z

And the other latest and greatest llama.cpp features

Summary by Sourcery

Enhancements:

Bump llama.cpp commit SHA to f667f1e6244e1f420512fa66692b7096ff17f366 to include gemma3n support and other recent updates

And the other latest and greatest llama.cpp features Signed-off-by: Eric Curtin <[email protected]>

sourcery-ai · 2025-06-27T14:07:23Z

Reviewer's Guide

This PR updates the llama.cpp build script to point at the latest upstream commit, thereby pulling in support for gemma3n and other recent llama.cpp enhancements.

File-Level Changes

Change	Details	Files
Bump llama.cpp commit SHA in build script	Replaced old SHA value with new commit hash	`container-images/scripts/build_llama_and_whisper.sh`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

ericcurtin · 2025-06-27T14:07:37Z

As requested by @giuseppe

sourcery-ai

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

The PR title mentions adding gemma3n support, but the diff only updates the llama.cpp SHA—please include the actual gemma3n integration changes or adjust the description.
Instead of hardcoding a raw SHA, consider pinning to a llama.cpp release tag or ensure the script explicitly checks out the specified commit after cloning for clarity.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The PR title mentions adding gemma3n support, but the diff only updates the llama.cpp SHA—please include the actual gemma3n integration changes or adjust the description.
- Instead of hardcoding a raw SHA, consider pinning to a llama.cpp release tag or ensure the script explicitly checks out the specified commit after cloning for clarity.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

giuseppe

LGTM

gemini-code-assist

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the llama.cpp submodule to a newer version, presumably to add support for the gemma3n model and incorporate the latest features from the llama.cpp project. The change involves updating the SHA hash in the build script.

Highlights

llama.cpp Update: The llama.cpp submodule is updated to commit f667f1e6244e1f420512fa66692b7096ff17f366.
gemma3n Support: The PR description indicates that this update brings support for gemma3n.
Latest llama.cpp Features: The PR description also mentions incorporating the latest llama.cpp features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request updates the llama.cpp commit SHA in the build_llama_and_whisper.sh script to include gemma3n support and other recent updates. It's important to ensure that the new commit is stable and doesn't introduce any regressions.

gemini-code-assist · 2025-06-27T14:09:35Z

container-images/scripts/build_llama_and_whisper.sh

@@ -268,7 +268,7 @@ clone_and_build_whisper_cpp() {
 }

 clone_and_build_llama_cpp() {
-  local llama_cpp_sha="97340b4c9924be86704dbf155e97c8319849ee19"
+  local llama_cpp_sha="f667f1e6244e1f420512fa66692b7096ff17f366"


Updating the llama.cpp SHA is a good practice to keep the project up-to-date with the latest features and bug fixes. However, it's crucial to verify that this specific commit has been thoroughly tested and is stable, especially considering the potential for breaking changes in external dependencies. Ensure that the integration tests pass with this new SHA.

rhatdan · 2025-06-27T14:35:49Z

LGTM

Want to pick up support for gemma3n

289e682

And the other latest and greatest llama.cpp features Signed-off-by: Eric Curtin <[email protected]>

ericcurtin requested review from rhatdan, bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver and engelmi as code owners June 27, 2025 14:07

sourcery-ai bot approved these changes Jun 27, 2025

View reviewed changes

giuseppe approved these changes Jun 27, 2025

View reviewed changes

gemini-code-assist bot reviewed Jun 27, 2025

View reviewed changes

rhatdan merged commit ca9885a into main Jun 27, 2025
10 of 16 checks passed

ericcurtin deleted the bump-llamacpp2 branch June 27, 2025 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Want to pick up support for gemma3n #1623

Want to pick up support for gemma3n #1623

Uh oh!

ericcurtin commented Jun 27, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Jun 27, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

ericcurtin commented Jun 27, 2025

Uh oh!

sourcery-ai bot left a comment

Uh oh!

giuseppe left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jun 27, 2025

Uh oh!

rhatdan commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Want to pick up support for gemma3n #1623

Want to pick up support for gemma3n #1623

Uh oh!

Conversation

ericcurtin commented Jun 27, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

ericcurtin commented Jun 27, 2025

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

giuseppe left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

ericcurtin commented Jun 27, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jun 27, 2025 •

edited

Loading