konflux: use shared pipelines for rocm, rocm-ubi, and cuda

[mikebonnet]

Summary by Sourcery

Introduce shared Tekton PipelineRun configurations for CUDA, ROCm, and ROCm-UBI builds on pull-request and push events using common pipelines

Enhancements:

• Consolidate GPU component build workflows to use shared pull-request-pipeline and push-pipeline definitions
• Parameterize image names, Dockerfile paths, and build platforms across CUDA, ROCm, and ROCm-UBI components

CI:

• Add PipelineRun YAMLs for cuda, rocm, and rocm-ubi triggered on pull requests to main
• Add PipelineRun YAMLs for cuda, rocm, and rocm-ubi triggered on pushes to main

[sourcery-ai]

Reviewer's Guide

This PR consolidates component-specific Tekton pipeline runs by adding uniform PipelineRun manifests for pull-request and push events across the cuda, rocm-ubi, and rocm folders, each delegating to shared pull-request and push pipelines with standardized annotations, parameters, labels, and workspaces.

Flow diagram for standardized PipelineRun manifest structure

flowchart TD
    Event["GitHub Event (pull_request or push)"]
    subgraph PipelineRun Manifest
        Params["Standardized Parameters"]
        Annotations["Standardized Annotations"]
        Labels["Standardized Labels"]
        Workspaces["Standardized Workspaces"]
        PipelineRef["Shared Pipeline Reference"]
    end
    Event --> PipelineRunManifest
    PipelineRunManifest --> Params
    PipelineRunManifest --> Annotations
    PipelineRunManifest --> Labels
    PipelineRunManifest --> Workspaces
    PipelineRunManifest --> PipelineRef
    PipelineRef -->|pull_request| pull-request-pipeline
    PipelineRef -->|push| push-pipeline

Loading

File-Level Changes

Change	Details	Files
Add pull-request PipelineRun manifests that reference a shared pull-request pipeline	Define common annotations and on-cel expression for PR triggers Set params: git-url, revision, output-image, image-expires-after, build-platforms, dockerfile Reference shared pull-request-pipeline in pipelineRef Mount git-auth workspace via secret	.tekton/cuda/cuda-pull-request.yaml .tekton/rocm-ubi/rocm-ubi-pull-request.yaml .tekton/rocm/rocm-pull-request.yaml
Add push PipelineRun manifests that reference a shared push pipeline	Define common annotations and on-cel expression for push triggers Set params: git-url, revision, output-image, build-platforms, dockerfile Reference shared push-pipeline in pipelineRef Mount git-auth workspace via secret	.tekton/cuda/cuda-push.yaml .tekton/rocm-ubi/rocm-ubi-push.yaml .tekton/rocm/rocm-push.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @mikebonnet, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes the necessary Tekton PipelineRun configurations to enable automated, event-driven CI/CD workflows for building CUDA, ROCm, and ROCm-UBI container images. By referencing shared build pipelines, it streamlines the process of generating these specialized images upon pull requests and pushes to the main branch, ensuring consistent and efficient image delivery within the Konflux environment.

Highlights

• Automated CI/CD for GPU-accelerated images: Introduced new Tekton PipelineRun configurations to automate the build process for CUDA, ROCm, and ROCm-UBI container images within the Konflux system.
• Leveraging shared pipelines: These new PipelineRun definitions are configured to utilize existing shared Tekton pipelines, specifically pull-request-pipeline for PR events and push-pipeline for push events, promoting reusability and consistency.
• Event-driven builds: Separate PipelineRun configurations are provided for both pull request and push events on the main branch, ensuring that image builds are triggered automatically upon code changes.
• Component-specific build parameters: Each PipelineRun is parameterized to specify the correct Dockerfile path (e.g., container-images/cuda/Containerfile) and output image name for its respective component (CUDA, ROCm, ROCm-UBI).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @mikebonnet - I've reviewed your changes - here's some feedback:

• There’s a lot of duplicated PipelineRun YAML—consider templatizing or generating these via Kustomize/Helm/YTT to DRY up the component‐specific variants.
• The multi‐line pipelinesascode.tekton.dev/on-cel-expression annotation may break YAML parsing—either keep it as a single line or use a proper block scalar (|).

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- There’s a lot of duplicated PipelineRun YAML—consider templatizing or generating these via Kustomize/Helm/YTT to DRY up the component‐specific variants.
- The multi‐line `pipelinesascode.tekton.dev/on-cel-expression` annotation may break YAML parsing—either keep it as a single line or use a proper block scalar (`|`).

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

The code changes introduce shared Tekton PipelineRun configurations for CUDA, ROCm, and ROCm-UBI builds on pull-request and push events using common pipelines. There are some critical syntax errors in the YAML configuration for build-platforms across all new files, which would prevent these pipelines from executing.