Skip to content

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 25, 2025

None of our tests should take more then 1 hour, so time them out and then need to figure out what is causing the issue.

Summary by Sourcery

CI:

  • Add timeout-minutes settings to all CI jobs (10 minutes for lint and unit-test jobs, 60 minutes for bats, bats-nocontainer, docker, and macOS jobs)

None of our tests should take more then 1 hour, so time them
out and then need to figure out what is causing the issue.

Signed-off-by: Daniel J Walsh <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Jun 25, 2025

Reviewer's Guide

Adds timeout configurations to the CI workflow to cap quick jobs at 10 minutes and longer test suites at 60 minutes, preventing excessively long runs.

File-Level Changes

Change Details Files
Introduce 10-minute timeouts for quick CI jobs
  • Add timeout-minutes: 10 to the lint job
  • Add timeout-minutes: 10 to the unit-test job
.github/workflows/ci.yml
Set 60-minute timeouts for longer-running test suites
  • Add timeout-minutes: 60 to the bats job
  • Add timeout-minutes: 60 to the bats-nocontainer job
  • Add timeout-minutes: 60 to the docker job
  • Add timeout-minutes: 60 to the macOS job
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin merged commit f70b13c into containers:main Jun 25, 2025
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[urgent] CI: jobs hanging and running forever blocking github actions resources of the whole org
2 participants