Reuse code for unit test execution rules

[sarroutbi]

Summary by Sourcery

Extract and reuse the common pytest command in Makefile test targets to remove duplication

Enhancements:

• Extract common pytest invocation into a Makefile variable (PYTEST_COMMON_CMD)
• Refactor unit-tests and unit-tests-verbose targets to use the new variable

[sourcery-ai]

Reviewer's Guide

Extract and reuse the common pytest command by introducing a Makefile variable and updating test targets to use it, reducing duplication.

Flow diagram for Makefile unit test command reuse

flowchart TD
    A[Define PYTEST_COMMON_CMD variable] --> B[unit-tests target uses PYTEST_COMMON_CMD]
    A --> C[unit-tests-verbose target uses PYTEST_COMMON_CMD with extra flags]

Loading

File-Level Changes

Change	Details	Files
Extract common pytest invocation into a reusable variable	Define PYTEST_COMMON_CMD variable for pytest invocation Update unit-tests target to use $(PYTEST_COMMON_CMD) Update unit-tests-verbose target to use $(PYTEST_COMMON_CMD)	Makefile

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @sarroutbi - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Summary of Changes

Hello @sarroutbi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the maintainability of the project's Makefile by centralizing the command used for executing unit tests. By defining a common variable for the base pytest command, it reduces duplication across different unit test targets, making future modifications to the test execution logic simpler and less error-prone.

Highlights

• Makefile Refactoring: I've introduced a new Makefile variable, PYTEST_COMMON_CMD, to encapsulate the base command for running unit tests. This centralizes the common pytest invocation.
• Code Duplication Reduction: The unit-tests and unit-tests-verbose targets in the Makefile now leverage the newly defined $(PYTEST_COMMON_CMD) variable, eliminating redundant command definitions and making the Makefile more maintainable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Makefile by introducing a PYTEST_COMMON_CMD variable to consolidate common pytest command invocations. This change enhances maintainability by reducing code duplication in the unit-tests and unit-tests-verbose targets. The implementation is straightforward and correctly preserves the existing behavior of these test targets. No issues of medium or higher severity were identified.

[engelmi]

LGTM

[rhatdan]

LGTM