-
Notifications
You must be signed in to change notification settings - Fork 234
Create tempdir when run as non-root user #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates the CI workflow to create the /mnt/tmp directory with explicit rwx permissions under sudo, enabling the pipeline to run successfully as a non-root user. Flow diagram for temp directory creation in CIflowchart TD
Start([Start CI Job])
CheckDir{Does /mnt/tmp exist?}
CreateDir["sudo mkdir -a=rwx -p /mnt/tmp"]
SetTempDir[Set TEMPDIR=/mnt/tmp]
RunValidate[Run make validate]
RunBats[Run make bats]
End([End])
Start --> CheckDir
CheckDir -- No --> CreateDir
CheckDir -- Yes --> SetTempDir
CreateDir --> SetTempDir
SetTempDir --> RunValidate --> RunBats --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhatdan - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/ci.yml:107` </location>
<code_context>
run: |
# /mnt has ~ 65 GB free disk space. / is too small.
- mkdir -p /mnt/tmp
+ sudo mkdir -a=rwx -p /mnt/tmp
TEMPDIR=/mnt/tmp
make validate
</code_context>
<issue_to_address>
The '-a=rwx' option is not valid for 'mkdir' and may cause the command to fail.
'-a=rwx' is not a valid option for 'mkdir'. To set permissions, use 'mkdir -m 0777 -p /mnt/tmp'. The current command will likely fail and halt the workflow.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
.github/workflows/ci.yml
Outdated
@@ -104,7 +104,7 @@ jobs: | |||
- name: run bats | |||
run: | | |||
# /mnt has ~ 65 GB free disk space. / is too small. | |||
mkdir -p /mnt/tmp | |||
sudo mkdir -a=rwx -p /mnt/tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The '-a=rwx' option is not valid for 'mkdir' and may cause the command to fail.
'-a=rwx' is not a valid option for 'mkdir'. To set permissions, use 'mkdir -m 0777 -p /mnt/tmp'. The current command will likely fail and halt the workflow.
Signed-off-by: Daniel J Walsh <[email protected]>
Summary by Sourcery
CI: