Skip to content

Create tempdir when run as non-root user #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 17, 2025

Summary by Sourcery

CI:

  • Use sudo with explicit permissions to create /mnt/tmp in the CI job

Copy link
Contributor

sourcery-ai bot commented Jun 17, 2025

Reviewer's Guide

This PR updates the CI workflow to create the /mnt/tmp directory with explicit rwx permissions under sudo, enabling the pipeline to run successfully as a non-root user.

Flow diagram for temp directory creation in CI

flowchart TD
  Start([Start CI Job])
  CheckDir{Does /mnt/tmp exist?}
  CreateDir["sudo mkdir -a=rwx -p /mnt/tmp"]
  SetTempDir[Set TEMPDIR=/mnt/tmp]
  RunValidate[Run make validate]
  RunBats[Run make bats]
  End([End])

  Start --> CheckDir
  CheckDir -- No --> CreateDir
  CheckDir -- Yes --> SetTempDir
  CreateDir --> SetTempDir
  SetTempDir --> RunValidate --> RunBats --> End
Loading

File-Level Changes

Change Details Files
Ensure tempdir creation supports non-root execution
  • Prefixed mkdir invocation with sudo
  • Added '-a=rwx' flag to set directory permissions
  • Retained '-p' to create parent directories if missing
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `.github/workflows/ci.yml:107` </location>
<code_context>
         run: |
            # /mnt has ~ 65 GB free disk space. / is too small.
-           mkdir -p /mnt/tmp
+           sudo mkdir -a=rwx -p /mnt/tmp
            TEMPDIR=/mnt/tmp
            make validate
</code_context>

<issue_to_address>
The '-a=rwx' option is not valid for 'mkdir' and may cause the command to fail.

'-a=rwx' is not a valid option for 'mkdir'. To set permissions, use 'mkdir -m 0777 -p /mnt/tmp'. The current command will likely fail and halt the workflow.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -104,7 +104,7 @@ jobs:
- name: run bats
run: |
# /mnt has ~ 65 GB free disk space. / is too small.
mkdir -p /mnt/tmp
sudo mkdir -a=rwx -p /mnt/tmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The '-a=rwx' option is not valid for 'mkdir' and may cause the command to fail.

'-a=rwx' is not a valid option for 'mkdir'. To set permissions, use 'mkdir -m 0777 -p /mnt/tmp'. The current command will likely fail and halt the workflow.

@rhatdan rhatdan merged commit eb45f50 into containers:main Jun 17, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants