Run bats test with TMPDIR pointing at /mnt/tmp

[rhatdan]

Summary by Sourcery

CI:

• Create a /mnt/tmp directory and set TEMPDIR to /mnt/tmp before running bats tests in CI to avoid disk space issues

[sourcery-ai]

Reviewer's Guide

This PR updates the GitHub Actions CI workflow to create and use /mnt/tmp as the temporary directory (TMPDIR) for bats tests, ensuring sufficient disk space.

Flow diagram for bats test execution with custom TMPDIR

flowchart TD
    Start([Start CI Job])
    Mkdir[/Create /mnt/tmp directory/]
    SetTMPDIR[Set TMPDIR to /mnt/tmp]
    Validate[Run make validate]
    Bats[Run make bats]
    End([End])

    Start --> Mkdir --> SetTMPDIR --> Validate --> Bats --> End

Loading

File-Level Changes

Change	Details	Files
Configure bats tests to use /mnt/tmp for temporary files	Add explanatory comment about /mnt having ~65 GB free Create /mnt/tmp directory before running tests Set TEMPDIR environment variable to /mnt/tmp	.github/workflows/ci.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[rhatdan]

@ericcurtin going to try this again, I am not sure why you reverted this one before. This should only run on Ubuntu systems.

[ericcurtin]

I dunno if this one makes a difference

[ericcurtin]

I'm gonna assume no, we got a green build

[sourcery-ai]

Hey @rhatdan - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ericcurtin]

There was several issues with the last version of this PR, this PR is different, failed on macOS, runroot path too long, I was battling with it for hours, this might be worth changing:

test/system/helpers.podman.bash
662:    for opt in root runroot tmpdir;do

to

test/system/helpers.podman.bash
662:    for opt in root tmpdir; do

to see if it works, if we hit this issue, this PR is different only does TMPDIR in one place. The runroot character length restriction was removed in the latest podman, I tried to install Ubuntu 25.04 podman on 24.04, it failed badly.

Hopefully we see a green build