Downgrade whisper

[ericcurtin]

We don't need the latest released version right now

Summary by Sourcery

Enhancements:

• Update whisper_cpp_sha variable to use an earlier commit hash for whisper.cpp

[sourcery-ai]

Reviewer's Guide

This PR pins the whisper-cpp dependency to a specific older commit by updating its SHA in the build script, effectively downgrading to a known working version.

File-Level Changes

Change	Details	Files
Downgrade whisper-cpp dependency by updating its commit hash in the build script	Replaced the previous SHA value with d682e150908e10caa4c15883c633d7902d385237	container-images/scripts/build_llama_and_whisper.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a dependency management decision by downgrading the whisper.cpp library to an earlier, specified version within the container image build process. The change is made because the latest version is not currently necessary for the project's requirements.

Highlights

• Dependency Downgrade: The specific commit SHA for the whisper.cpp library used in the build_llama_and_whisper.sh script has been changed to an older version. This effectively downgrades the whisper.cpp dependency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request downgrades the whisper.cpp dependency to an older commit SHA, rolling back approximately four months of development. The primary feedback emphasizes the critical need for a detailed justification in the PR description. This justification should cover the specific reasons for the downgrade, addressing any issues with newer versions, and an assessment of potential regressions (e.g., security vulnerabilities, bugs, performance) introduced by using this older commit. A suggestion is also provided to add an inline comment in the code to document the reason for pinning this specific version, enhancing long-term maintainability.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `container-images/scripts/build_llama_and_whisper.sh:251` </location>
<code_context>
-  local whisper_cpp_sha="51c6961c7b64b406833f4b6a4a20e67142f69225"
+  local whisper_cpp_sha="d682e150908e10caa4c15883c633d7902d385237"
   whisper_flags+=("-DBUILD_SHARED_LIBS=OFF")
   # See: https://github.com/ggml-org/llama.cpp/blob/master/docs/build.md#compilation-options
   if [ "$containerfile" = "musa" ]; then
</code_context>

<issue_to_address>
Reference points to llama.cpp docs instead of whisper.cpp build instructions

Please update the link to point to the whisper.cpp build documentation to ensure maintainers reference the correct instructions.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
  # See: https://github.com/ggml-org/llama.cpp/blob/master/docs/build.md#compilation-options
=======
  # See: https://github.com/ggerganov/whisper.cpp/blob/master/docs/build.md#compilation-options
>>>>>>> REPLACE

</suggested_fix>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}