Convert tabs to spaces

[ericcurtin]

Saw this in github ui

Summary by Sourcery

CI:

• Replace tabs with spaces in .github/workflows/ci.yml for Bats job steps

[sourcery-ai]

Reviewer's Guide

This PR replaces tab characters with spaces for indentation within the .github/workflows/ci.yml run sections, standardizing the CI workflow formatting.

File-Level Changes

Change	Details	Files
Replaced tab indentation with spaces in CI workflow run blocks	Converted leading tabs to spaces in multiline run scripts Applied consistent indentation across the three run steps (bats, bats-nocontainer, one-line script)	.github/workflows/ci.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `.github/workflows/ci.yml:106` </location>
<code_context>
         run: |
-	   mkdir /mnt/tmp
-	   export TMPDIR=/mnt/tmp
+           mkdir /mnt/tmp
+           export TMPDIR=/mnt/tmp
            make validate
</code_context>

<issue_to_address>
Use mkdir -p for idempotent directory creation

`mkdir -p /mnt/tmp` will prevent errors if the directory already exists, ensuring the step doesn't fail on reruns.

Suggested implementation:

```
           mkdir -p /mnt/tmp

```

```
           mkdir -p /mnt/tmp

```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Use mkdir -p for idempotent directory creation

mkdir -p /mnt/tmp will prevent errors if the directory already exists, ensuring the step doesn't fail on reruns.

Suggested implementation:

           mkdir -p /mnt/tmp

           mkdir -p /mnt/tmp

[sarroutbi]

LGTM

[ericcurtin]

/mnt doesn't exist on macOS:

export TMPDIR=$(mktemp -d)

is more portable

[ericcurtin]

Merging this because the build is broken, it's more important to get the build green again

[ericcurtin]

@rhatdan just checking you didn't pick /mnt for a specific reason? Hoping it didn't have any extra disk space or something, merged this quickly as the mkdir /mnt/tmp broke our macOS build

[rhatdan]

The issue is on Linux systems, the /mnt is a large amount of space as I understand it.

If you look at the docker one, it says:

  # /mnt has ~ 65 GB free disk space. / is too small.

So for at lease Linux tests we should be setting TMPDIR to point at /mnt.

[ericcurtin]

@rhatdan maybe it works... We might need to if around it for macOS though, if definitely broke macOS... But there's so much instability now, it's hard to keep track