Skip to content

Bump to v0.9.2 #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Bump to v0.9.2 #1537

merged 1 commit into from
Jun 16, 2025

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 16, 2025

Summary by Sourcery

Chores:

  • Update version number in pyproject.toml, version.py, and RPM spec to 0.9.2.

Signed-off-by: Daniel J Walsh <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Jun 16, 2025

Reviewer's Guide

This PR increments the project version from 0.9.1 to 0.9.2 consistently across configuration, source code, and packaging metadata.

File-Level Changes

Change Details Files
Bump project version to 0.9.2
  • Updated version in pyproject.toml
  • Updated return value of version() in ramalama/version.py
  • Updated RPM spec version macro
pyproject.toml
ramalama/version.py
rpm/python-ramalama.spec

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rhatdan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's version number to 0.9.2. This change is reflected in the Python project metadata, the internal version reporting function, and the RPM spec file, ensuring consistency across the project's build and distribution mechanisms.

Highlights

  • Version Bump: Updated the project version from 0.9.1 to 0.9.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the project version from 0.9.1 to 0.9.2 across pyproject.toml, ramalama/version.py, and rpm/python-ramalama.spec. Consider centralizing the version string to a single source of truth for future maintainability.

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "ramalama"
version = "0.9.1"
version = "0.9.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider establishing this version field in pyproject.toml as the single source of truth. Other parts of the system could then derive the version from this file.

@@ -2,7 +2,7 @@


def version():
return "0.9.1"
return "0.9.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider dynamically reading the version from pyproject.toml at runtime using importlib.metadata.version('ramalama') to establish a single source of truth.

@@ -1,7 +1,7 @@
%global pypi_name ramalama
%global forgeurl https://github.com/containers/%{pypi_name}
# see ramalama/version.py
%global version0 0.9.1
%global version0 0.9.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider modifying the RPM build process to dynamically extract the version from pyproject.toml to establish a single source of truth.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smooge does the rpm spec absolutely need this line?

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin
Copy link
Member

LGTM... @smooge @lsm5 anyway we can make packit play nicer and upgrade all our rpms every Monday. We are still beta, we want every rpm updated every monday. EPEL9 or other older platforms can be left out of date if needs be and are too old

@lsm5
Copy link
Member

lsm5 commented Jun 16, 2025

LGTM... @smooge @lsm5 anyway we can make packit play nicer and upgrade all our rpms every Monday.

If you're talking the official distro builds, Packit responds to github release events by creating Fedora PRs that have to be merged by a human. Also, the rpms first go to updates-testing and there's some soak time there before it lands in stable updates.

We are still beta, we want every rpm updated every monday. EPEL9 or other older platforms can be left out of date if needs be and are too old

The human merges of fedora PRs can be timed that way.

@lsm5
Copy link
Member

lsm5 commented Jun 16, 2025

something's weird in the packit job. I don't get why it's trying to fetch the v0.9.2 tag

@rhatdan rhatdan merged commit e0e3ee1 into containers:main Jun 16, 2025
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants