Not sure this is supposed to be here

[ericcurtin]

Think it's only meant for the:

container-images/scripts/build-cli.sh

version, it's breaking podman on my bootc system and replacing /usr/bin/podman with a broken /usr/bin/podman-remote symlink.

Summary by Sourcery

Bug Fixes:

• Prevent the build_llama_and_whisper.sh script from linking /usr/bin/podman-remote to /usr/bin/podman, which could break the host podman executable

[sourcery-ai]

Reviewer's Guide

This PR removes the forced symlink of podman-remote to podman from the build_llama_and_whisper.sh script to prevent overwriting the host's podman binary.

Flow diagram for podman symlink removal in build_llama_and_whisper.sh

flowchart TD
    A[Start install_ramalama] --> B{Was podman symlink created?}
    B -- Before PR --> C[ln -sf /usr/bin/podman-remote /usr/bin/podman]
    C --> D[Continue install_ramalama]
    B -- After PR --> D
    D[Continue install_ramalama] --> E[Check /run/ramalama]
    E --> F[Install ramalama if present]
    E --> G[End if not present]

Loading

File-Level Changes

Change	Details	Files
Eliminate podman-remote symlink creation	Removed ln -sf /usr/bin/podman-remote /usr/bin/podman from install_ramalama	container-images/scripts/build_llama_and_whisper.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to fix a specific issue encountered on bootc systems where a build script was incorrectly creating a symlink for the podman command, leading to a broken setup. The change removes this problematic symlink creation from the script where it was deemed unnecessary.

Highlights

• Symlink Removal: Removed the explicit creation of a symlink from /usr/bin/podman to /usr/bin/podman-remote within the install_ramalama function in the build_llama_and_whisper.sh script.
• Fix for Bootc Systems: This change addresses an issue reported by the author where this symlink creation was causing the podman command to break on bootc systems by replacing the expected binary with a potentially non-functional symlink.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request correctly removes a symlink creation (ln -sf /usr/bin/podman-remote /usr/bin/podman) from the build_llama_and_whisper.sh script. This symlink was causing issues by breaking the host's podman executable when the script was run in certain environments. The removal addresses this bug, as the symlink is likely only intended for specific container images built by other scripts.

[rhatdan]

This is needed in the ramalama-cli install at least.

[rhatdan]

You could just move this below the if /run/ramalama line below, or we should move it to the containerfile that installs podman-remote.

[rhatdan]

Actually after further search this is correct.
LGTM