Skip to content

Suggest using uv pip install to get missing module #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Suggest using uv pip install to get missing module #1532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ramalama/huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@

missing_huggingface = """
Optional: Huggingface models require the huggingface-cli module.
These modules can be installed via PyPi tools like pip, pip3, pipx, or via
This module can be installed via PyPi tools like uv, pip, pip3, pipx, or via
distribution package managers like dnf or apt. Example:
pip install huggingface_hub
uv pip install huggingface_hub
Comment on lines +18 to +20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Remove or clarify the 'uv' prefix around pip commands

The 'uv' prefix may confuse users unless it's intentional. Please use 'pip install huggingface_hub' or explain what 'uv' refers to if it's required.

"""


Expand Down Expand Up @@ -228,7 +228,7 @@ def hf_pull(self, args, model_path, directory_path):

def push(self, _, args):
if not self.hf_cli_available:
raise NotImplementedError(missing_huggingface)
raise NotImplementedError(self.get_missing_message())
proc = run_cmd(
[
"huggingface-cli",
Expand Down
6 changes: 3 additions & 3 deletions ramalama/modelscope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@

missing_modelscope = """
Optional: ModelScope models require the modelscope module.
These modules can be installed via PyPi tools like pip, pip3, pipx, or via
This module can be installed via PyPi tools like uv, pip, pip3, pipx, or via
distribution package managers like dnf or apt. Example:
pip install modelscope
uv pip install modelscope
Comment on lines +15 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Remove or clarify the 'uv' prefix around pip commands

The 'uv' prefix may confuse users if not explained. Use 'pip install modelscope' or clarify what 'uv' refers to if it's intentional.

"""


Expand Down Expand Up @@ -120,7 +120,7 @@ def ms_pull(self, args, model_path, directory_path):

def push(self, _, args):
if not self.ms_available:
raise NotImplementedError(missing_modelscope)
raise NotImplementedError(self.get_missing_message())
proc = run_cmd(
[
"modelscope",
Expand Down
Loading