Skip to content

Update black target version #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

Hasnep
Copy link
Contributor

@Hasnep Hasnep commented Jun 12, 2025

The black formatter can make better formatting suggestions if it knows the correct versions of Python being targeted.

Summary by Sourcery

Enhancements:

  • Extend Black's target-version in pyproject.toml to include Python 3.10 through 3.13 instead of Python 3.6

Copy link
Contributor

sourcery-ai bot commented Jun 12, 2025

Reviewer's Guide

The PR adjusts Black’s configuration in pyproject.toml to target newer Python versions by replacing the existing single-version list with an updated list covering py310–py313.

File-Level Changes

Change Details Files
Expanded Black’s target-version list to include recent Python releases.
  • Removed ‘py36’ from the target-version array
  • Added ‘py310’, ‘py311’, ‘py312’, ‘py313’ to the array
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Hasnep Hasnep force-pushed the update-black-target-version branch from 0c646f1 to b5c4920 Compare June 12, 2025 11:07
@ericcurtin
Copy link
Member

ericcurtin commented Jun 12, 2025

I think we have to be careful about updating python version required for the sake of linters. I'm gonna let the build run anyway

@Hasnep Hasnep force-pushed the update-black-target-version branch from b5c4920 to 1b2867e Compare June 13, 2025 00:04
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @Hasnep

@rhatdan rhatdan merged commit 83363e7 into containers:main Jun 13, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants