-
Notifications
You must be signed in to change notification settings - Fork 246
make ramalama-client-core send default model to server #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates the client core to always include a default model in outgoing server requests and consolidates helper utilities into the Ramalamashell class for improved code organization. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rhatdan - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
data = { | ||
"stream": True, | ||
"messages": self.conversation_history, | ||
"model": self.models[0], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable
)
271e0b4
to
7f4187e
Compare
Also move most of the helper functions into ramalamashell class Signed-off-by: Daniel J Walsh <[email protected]>
LGTM |
Also move most of the helper functions into ramalamashell class
Summary by Sourcery
Enable automatic sending of a default model from the client to the server and restructure helper functions into the RamalamaShell class.
New Features:
Enhancements: