Skip to content

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 29, 2025

Also move most of the helper functions into ramalamashell class

Summary by Sourcery

Enable automatic sending of a default model from the client to the server and restructure helper functions into the RamalamaShell class.

New Features:

  • Make the client send a default model to the server when none is specified

Enhancements:

  • Move helper functions into the RamalamaShell class for improved organization

Copy link
Contributor

sourcery-ai bot commented May 29, 2025

Reviewer's Guide

This PR updates the client core to always include a default model in outgoing server requests and consolidates helper utilities into the Ramalamashell class for improved code organization.

File-Level Changes

Change Details Files
Include default model in server requests
  • Added fallback constant for defaultModel
  • Enhanced request builder to set defaultModel when none provided
  • Augmented send logic to attach model field to payload
libexec/ramalama/ramalama-client-core
Refactor helper functions into Ramalamashell class
  • Moved parseArgs, formatResponse, buildHeaders into class methods
  • Removed standalone helper function definitions
  • Updated internal calls to invoke the new class methods
libexec/ramalama/ramalama-client-core

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rhatdan - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines 89 to 101
data = {
"stream": True,
"messages": self.conversation_history,
"model": self.models[0],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)

@rhatdan rhatdan force-pushed the libexec branch 5 times, most recently from 271e0b4 to 7f4187e Compare May 29, 2025 20:08
Also move most of the helper functions into ramalamashell class

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented May 29, 2025

@nathan-weinberg nathan-weinberg self-requested a review May 30, 2025 00:58
@bmahabirbu
Copy link
Collaborator

LGTM

@ericcurtin ericcurtin merged commit fbca7ec into containers:main May 30, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants