Skip to content

Conversation

@Luap99
Copy link
Member

@Luap99 Luap99 commented May 28, 2025

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 28, 2025
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented May 28, 2025

@containers/podman-maintainers PTAL

@mtrmac
Copy link
Contributor

mtrmac commented May 28, 2025

To help future selves, is there a specific reason to update now?

@Luap99
Copy link
Member Author

Luap99 commented May 28, 2025

I see failing test on #26221 if not doing a full vendor so I thought I do that first without my new changes that will need other test fixes as well.
And other than that we should do this often enough to at least make sure there are new regressions at least until we have a better vendor process.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 089547d into containers:main May 28, 2025
85 checks passed
@Luap99 Luap99 deleted the vendor branch May 28, 2025 18:01
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants