remote: don't print bogus error when starting container attached

[Luap99]

This looks like debug leftover, in any case this is not an error so simply remove the line.

Fixes #25965

Does this PR introduce a user-facing change?

Fixed a bug where podman-remote start --attach would print a bogus error when the container was created with --rm.

[Luap99]

/hold

Please don't add "/lgtm" right away, we generally require two reviews from maintainers first.

[Honny1]

LGTM, Thank you. I think --rm doesn't work for podman create, but that's not the subject of this PR.
/approve

[benoitf]

can it be cherry-picked to 5.5 branch once approved/merged ? thanks

[Luap99]

@benoitf Please do not rerun blindly tests, the log clearly shows my new tests failing which means (looking at the high number of failures) it is flaky and thus this cannot be merged like this.

[Honny1]

Nice fix of tests. I think test: Podman logs [It] since time 2017-08-07: journald is flaky.

[Luap99]

I think test: Podman logs [It] since time 2017-08-07: journald is flaky.

Yes, every podman logs test is flaky in some way. journald is just super unreliable, #24220

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[baude]

/cherry-pick v5.5
/lgtm

[openshift-cherrypick-robot]

@baude: once the present PR merges, I will cherry-pick it on top of v5.5 in a new PR and assign it to you.

In response to this:

/cherry-pick v5.5
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@baude: new pull request created: #25976

In response to this:

/cherry-pick v5.5
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.