Skip to content

Conversation

@flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Jun 2, 2022

Feature of additional build context added here containers/buildah#3978
already exists on podman following PR just enables this feature of
podman-remote and podman on macOS setups.

Follow up to : #14320

Does this PR introduce a user-facing change?

Enables additional build context for podman-remote and macOS using --build-context

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@flouthoc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@flouthoc flouthoc added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@flouthoc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None and removed release-note labels Jun 2, 2022
@flouthoc flouthoc removed the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Jun 2, 2022
@Luap99
Copy link
Member

Luap99 commented Jun 2, 2022

How can this work? There no logic to actually copy the additional build context to the remote system.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jun 2, 2022

@Luap99 Additional build context can also be other container images and url sources or git repos, so if you see uncommented tests there are still some tests commented where additional context exists on hosts while other additional build context can stilll be used by remote users where additional context is image,url or git repo.

Additional build context from host to remote is still a spike since this feature is new for both docker and buildah and they don't expose API for it as of now so tarring up and posting context from host to remote might be too early implementation hence it is still skipped for remote users.

PS: Same reason is that we should avoid listing this in swagger as of now.

@Luap99
Copy link
Member

Luap99 commented Jun 2, 2022

Additional build context can also be other container images and url sources or git repos, so if you see uncommented tests there are still some tests commented where additional context exists on hosts while other additional build context can stilll be used by remote users where additional context is image,url or git repo.

This should be documented then. The current podman-build page doesn't event mention that this was not supported via remote.

…remote

Feature of additional build context added here containers/buildah#3978
already exists on `podman` following PR just enables this feature of
`podman-remote` and `podman on macOS` setups.

Signed-off-by: Aditya R <[email protected]>
@flouthoc flouthoc force-pushed the support-additional-build-context-on-remote branch from 40e2969 to cfc0f9c Compare June 2, 2022 12:12
@flouthoc
Copy link
Collaborator Author

flouthoc commented Jun 2, 2022

Additional build context can also be other container images and url sources or git repos, so if you see uncommented tests there are still some tests commented where additional context exists on hosts while other additional build context can stilll be used by remote users where additional context is image,url or git repo.

This should be documented then. The current podman-build page doesn't event mention that this was not supported via remote.

Yes docs needs to state this, update docs.

@TomSweeneyRedHat
Copy link
Member

Changes as they are LGTM, but we need to update the docs before this goes.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jun 3, 2022

Changes as they are LGTM, but we need to update the docs before this goes.

@TomSweeneyRedHat Already updated docs in the PR.

@flouthoc flouthoc force-pushed the support-additional-build-context-on-remote branch from cfc0f9c to 00c52fa Compare June 3, 2022 15:46
@flouthoc flouthoc force-pushed the support-additional-build-context-on-remote branch from 00c52fa to 22e442e Compare June 3, 2022 18:17
@TomSweeneyRedHat
Copy link
Member

LGTM
and happy green test buttons

@rhatdan
Copy link
Member

rhatdan commented Jun 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 48a4e6d into containers:main Jun 6, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants