-
Notifications
You must be signed in to change notification settings - Fork 2.9k
remote: enable support for additional --build-context on macOS and remote
#14453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote: enable support for additional --build-context on macOS and remote
#14453
Conversation
|
@flouthoc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@flouthoc: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
How can this work? There no logic to actually copy the additional build context to the remote system. |
|
@Luap99 Additional build context can also be other container images and url sources or git repos, so if you see uncommented tests there are still some tests commented where additional context exists on hosts while other additional build context can stilll be used by remote users where additional context is Additional build context from host to remote is still a spike since this feature is new for both docker and buildah and they don't expose API for it as of now so tarring up and posting context from host to remote might be too early implementation hence it is still skipped for remote users. PS: Same reason is that we should avoid listing this in swagger as of now. |
This should be documented then. The current podman-build page doesn't event mention that this was not supported via remote. |
…remote Feature of additional build context added here containers/buildah#3978 already exists on `podman` following PR just enables this feature of `podman-remote` and `podman on macOS` setups. Signed-off-by: Aditya R <[email protected]>
40e2969 to
cfc0f9c
Compare
Yes docs needs to state this, update docs. |
|
Changes as they are LGTM, but we need to update the docs before this goes. |
@TomSweeneyRedHat Already updated docs in the PR. |
cfc0f9c to
00c52fa
Compare
Signed-off-by: Aditya R <[email protected]>
00c52fa to
22e442e
Compare
|
LGTM |
|
/lgtm |
Feature of additional build context added here containers/buildah#3978
already exists on
podmanfollowing PR just enables this feature ofpodman-remoteandpodman on macOSsetups.Follow up to : #14320
Does this PR introduce a user-facing change?