-
Notifications
You must be signed in to change notification settings - Fork 65
chore(test): function calling test #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ import type { Locator, Page } from '@playwright/test'; | |
import { AILabBasePage } from './ai-lab-base-page'; | ||
import { handleConfirmationDialog, podmanAILabExtension } from '@podman-desktop/tests-playwright'; | ||
import { AILabCreatingModelServicePage } from './ai-lab-creating-model-service-page'; | ||
import { AILabServiceDetailsPage } from './ai-lab-service-details-page'; | ||
|
||
export class AiModelServicePage extends AILabBasePage { | ||
readonly additionalActions: Locator; | ||
|
@@ -66,6 +67,28 @@ export class AiModelServicePage extends AILabBasePage { | |
return (await this.getAllTableRows()).length; | ||
} | ||
|
||
async openServiceDetails(modelName: string): Promise<AILabServiceDetailsPage> { | ||
const serviceRow = await this.getServiceByModel(modelName); | ||
if (serviceRow === undefined) { | ||
throw new Error(`Model [${modelName}] service doesn't exist`); | ||
} | ||
const serviceRowName = serviceRow.getByRole('cell').nth(3); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please open follow up issue to address missing aria-labels in the row definition. We should not rely on order of the cells. This is out of scope of this PR. |
||
await serviceRowName.click(); | ||
return new AILabServiceDetailsPage(this.page, this.webview); | ||
} | ||
|
||
async getServiceByModel(modelName: string): Promise<Locator | undefined> { | ||
const rows = await this.getAllTableRows(); | ||
for (let rowNum = 1; rowNum < rows.length; rowNum++) { | ||
gastoner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
//skip header | ||
const serviceModel = rows[rowNum].getByRole('cell').nth(4); | ||
if ((await serviceModel.textContent()) === modelName) { | ||
return rows[rowNum]; | ||
} | ||
} | ||
return undefined; | ||
} | ||
|
||
private async getAllTableRows(): Promise<Locator[]> { | ||
return await this.webview.getByRole('row').all(); | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.