refactor: add a TaskRunner class #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <[email protected]>
axel7083
reviewed
Apr 11, 2025
axel7083
reviewed
Apr 11, 2025
Signed-off-by: Philippe Martin <[email protected]>
Signed-off-by: Philippe Martin <[email protected]>
axel7083
reviewed
Apr 11, 2025
|
|
||
| export class ApplicationManager extends Publisher<ApplicationState[]> implements Disposable { | ||
| #applications: ApplicationRegistry<ApplicationState>; | ||
| protectTasks: Set<string> = new Set(); | ||
| #disposables: Disposable[]; | ||
| #taskRunner: TaskRunner; |
There was a problem hiding this comment.
if task runner is stored like that it should be disposable, and be disposed if the class is disposed, cancelling any pending tasks it is managing ?
There was a problem hiding this comment.
That would be a good enhancement, but as this is only a refactoring, I don't want to change any behaviour
axel7083
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin [email protected]
What does this PR do?
Add a TaskRunner class to separate task logic and implementation
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Related to #2628
How to test this PR?
Start recipes and check everything works as before