Skip to content

fix: model info was modified async causing issue in recipe start #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix: model info was modified async causing issue in recipe start #2790

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da2c19f
fix: model info was modified async causing issue in recipe start
jeffmaury Apr 1, 2025
e50c42b
fix: apply code refactoring suggestion from @gastoner
jeffmaury Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions packages/backend/src/managers/modelsManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,6 @@ export class ModelsManager implements Disposable {
this.telemetry.logUsage(eventName, { 'model.id': event.id, durationSeconds: event.duration });
}

// refresh model lists on event completion
await this.getLocalModelsFromDisk();
this.sendModelsInfo().catch((err: unknown) => {
console.error('Something went wrong while sending models info.', err);
});

// cleanup downloader
this.#downloaders.delete(event.id);
}
Expand Down Expand Up @@ -371,6 +365,8 @@ export class ModelsManager implements Disposable {

// perform download
await downloader.perform(model.id);
await this.updateModelInfos();

return downloader.getTarget();
}

Expand All @@ -395,7 +391,18 @@ export class ModelsManager implements Disposable {
uploader.onEvent(event => this.onDownloadUploadEvent(event, 'upload'), this);

// perform download
return uploader.perform(model.id);
const path = uploader.perform(model.id);
await this.updateModelInfos();

return path;
}

private async updateModelInfos(): Promise<void> {
// refresh model lists on event completion
await this.getLocalModelsFromDisk();
this.sendModelsInfo().catch((err: unknown) => {
console.error('Something went wrong while sending models info.', err);
});
}

async getModelMetadata(modelId: string): Promise<Record<string, unknown>> {
Expand Down
Loading