-
Notifications
You must be signed in to change notification settings - Fork 65
feat: make AI lab providing swagger UI for the openAI docs #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes containers#2695 Signed-off-by: Florent Benoit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works great, can access the doc and send requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple remark: if the API server is not started, I think we should not expose a link in the UI at all.
All I would love to see the model name displayed in the Swagger UI rather that the generic "AI Lab Inference Server"
const aiLabPort = this.configurationRegistry.getExtensionConfiguration().apiPort; | ||
// add in the URL the port of the inference server | ||
const aiLabDocsLink = `http://localhost:${aiLabPort}/api-docs/${config.port}`; | ||
console.log('set the ai lab docs link to', aiLabDocsLink); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ?
in which case the server is not started ?
it could be another path parameter, but I would call it improvement as it's not the case today |
Signed-off-by: Florent BENOIT <[email protected]>
…ontainers#2703)" This reverts commit 8de0c18 Signed-off-by: axel7083 <[email protected]>
* Revert "feat: make AI lab providing swagger UI for the openAI docs (#2703)" This reverts commit 8de0c18 Signed-off-by: axel7083 <[email protected]> * fix: pnpm-lock Signed-off-by: axel7083 <[email protected]> --------- Signed-off-by: axel7083 <[email protected]>
* Revert "feat: make AI lab providing swagger UI for the openAI docs (#2703)" This reverts commit 8de0c18 Signed-off-by: axel7083 <[email protected]> * fix: pnpm-lock Signed-off-by: axel7083 <[email protected]> --------- Signed-off-by: axel7083 <[email protected]> (cherry picked from commit 86db349)
* Revert "feat: make AI lab providing swagger UI for the openAI docs (#2703)" This reverts commit 8de0c18 Signed-off-by: axel7083 <[email protected]> * fix: pnpm-lock Signed-off-by: axel7083 <[email protected]> --------- Signed-off-by: axel7083 <[email protected]> (cherry picked from commit 86db349) Co-authored-by: axel7083 <[email protected]>
…s#2703) fixes containers#2695 Signed-off-by: Florent BENOIT <[email protected]>
…s#2703) fixes containers#2695 Signed-off-by: Florent BENOIT <[email protected]>
…s#2703) fixes containers#2695 Signed-off-by: Florent BENOIT <[email protected]>
…s#2703) fixes containers#2695 Signed-off-by: Florent BENOIT <[email protected]>
…s#2703) fixes containers#2695 Signed-off-by: Florent BENOIT <[email protected]>
…2735) * feat: make AI lab providing swagger UI for the openAI docs (#2703) fixes #2695 Signed-off-by: Florent BENOIT <[email protected]>
What does this PR do?
inference OCI images may not have Swagger UI, so start the swagger UI in Podman AI Lab and make calls from there to the inference server
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #2695
How to test this PR?
start a new playground for example, then go to the services list, click on "swagger documentation"
you'll notice you're using Swagger UI and you can query the inference server URL from there
so swagger UI is served by AI Lab
unit test added