Skip to content

fix: failure in WSLUploader if models folder has spaces #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: failure in WSLUploader if models folder has spaces #2395

merged 2 commits into from
Jan 16, 2025

Conversation

jeffmaury
Copy link
Collaborator

Fixes #2394

What does this PR do?

Handle cases where the model file path has spaces when uploading on WSL

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#2394

How to test this PR?

This must be executed only on Windows/WSL

  1. Create a folder with spaces
  2. Configure it as the Podman AI Lab models folder
  3. Download a model
  4. Start inference server

@jeffmaury jeffmaury requested review from benoitf and a team as code owners January 15, 2025 15:31
@jeffmaury jeffmaury requested review from cdrage, deboer-tim, axel7083, gastoner and feloy and removed request for cdrage and deboer-tim January 15, 2025 15:31
axel7083
axel7083 reviewed Jan 15, 2025
View reviewed changes
axel7083
axel7083 reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand if this fixes the problem for the path to the model, or the model file itself which contains spaces ?

@jeffmaury
Copy link
Collaborator Author

I don't understand if this fixes the problem for the path to the model, or the model file itself which contains spaces ?

Both

feloy
feloy reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Windows, I can start a service correctly when the path of the model contains a space.

I will test on Linux/mac to be sure this does not introduce a regression on these platforms. (edit: it appears that the code is executed only on Windows, so no problem)

Code wise, it would be interesting to have a utility function which returns the correct Window path

axel7083
axel7083 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury merged commit 2cc54d7 into containers:main Jan 16, 2025
7 checks passed
@jeffmaury jeffmaury deleted the GH-2394 branch January 16, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@axel7083 axel7083 axel7083 approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@gastoner gastoner Awaiting requested review from gastoner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't start inference server if models folder has spaces on Windows/WSL
3 participants
@jeffmaury @feloy @axel7083