Skip to content

fix(ui): svelte check error create service #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix(ui): svelte check error create service #1994

merged 1 commit into from
Oct 25, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Oct 25, 2024 •
edited
Loading

What does this PR do?

Fix the svelte check error

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1897
Related to #1993

How to test this PR?

  • unit test has been added

@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners October 25, 2024 08:44
This was referenced Oct 25, 2024
Closed
Merged
benoitf
benoitf approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technical debt (non-blocking): it looks like it's not natural to have on:input in create service as it's possible to have a bidirectional value

maybe we need to provide the NumberInput as a ui component (there is one but in Podman Desktop)

@axel7083 axel7083 merged commit 98580a5 into containers:main Oct 25, 2024
6 checks passed
@benoitf benoitf mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner

@cdrage cdrage Awaiting requested review from cdrage cdrage is a code owner automatically assigned from containers/podman-desktop-reviewers

@SoniaSandler SoniaSandler Awaiting requested review from SoniaSandler SoniaSandler is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CreateService.svelte component to use the newer Input component
2 participants
@axel7083 @benoitf