Skip to content

feat: adding icon for non downloaded models #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 28, 2024
Merged

feat: adding icon for non downloaded models #1866

merged 7 commits into from
Oct 28, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Oct 9, 2024 •
edited
Loading

What does this PR do?

Adding icon for non-downloaded models in the catalog.

Screenshot / video of UI

image

image

image

What issues does this PR fix or reference?

Fixes #1848

How to test this PR?

  • unit tests has been provided

@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners October 9, 2024 11:40
benoitf
benoitf reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO here you should define a StatusIcon in ailab extending the one from ui library

then you'll use all the time the custom Ai lab StatusIcon component

like you don't have the if/else on the consumer side, only in the status component

@axel7083
Copy link
Contributor Author

axel7083 commented Oct 9, 2024

IMHO here you should define a StatusIcon in ailab extending the one from ui library

Moving to draft

@axel7083 axel7083 marked this pull request as draft October 9, 2024 13:26
MariaLeonova
MariaLeonova reviewed Oct 10, 2024
View reviewed changes
Copy link

@MariaLeonova MariaLeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axel7083 looks good from the UI side!

jeffmaury
jeffmaury approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axel7083 axel7083 force-pushed the feature/non-downloaded-models-icon branch from 57fcdde to 3fd03a0 Compare October 25, 2024 08:27
@axel7083
Copy link
Contributor Author

#1993 is required

@axel7083 axel7083 mentioned this pull request Oct 25, 2024
Merged
@axel7083 axel7083 force-pushed the feature/non-downloaded-models-icon branch from 3fd03a0 to fda9330 Compare October 25, 2024 09:13
@axel7083
fix(ui): model tests
1831188 
Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 marked this pull request as ready for review October 25, 2024 09:29
@axel7083 axel7083 requested a review from benoitf October 25, 2024 09:30
benoitf
benoitf approved these changes Oct 25, 2024
View reviewed changes
axel7083 and others added 2 commits October 25, 2024 16:01
@axel7083 @benoitf
Update packages/frontend/src/lib/icons/ModelStatusIcon.svelte
8810386 
Co-authored-by: Florent BENOIT <[email protected]>
Signed-off-by: axel7083 <[email protected]>
@axel7083
fix: prettier
feca925 
Signed-off-by: axel7083 <[email protected]>
@axel7083 axel7083 enabled auto-merge (squash) October 28, 2024 08:53
@axel7083 axel7083 merged commit 288f3ab into containers:main Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaLeonova MariaLeonova MariaLeonova left review comments

@benoitf benoitf benoitf approved these changes

@jeffmaury jeffmaury jeffmaury approved these changes

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from containers/podman-desktop-reviewers

@SoniaSandler SoniaSandler Awaiting requested review from SoniaSandler SoniaSandler is a code owner automatically assigned from containers/podman-desktop-reviewers

@feloy feloy Awaiting requested review from feloy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new icon for non-downloaded models
4 participants
@axel7083 @benoitf @jeffmaury @MariaLeonova