CI: test fuse manager #1914
Merged
CI: test fuse manager #1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
force-pushed
the
fuse-manager-tests
branch
5 times, most recently
from
2146b95 to
4e7f00b
Compare
ktock
force-pushed
the
fuse-manager-tests
branch
2 times, most recently
from
0d9e1bf to
2fe7581
Compare
ktock
force-pushed
the
fuse-manager-tests
branch
from
2fe7581 to
ce664b9
Compare
ktock
force-pushed
the
fuse-manager-tests
branch
8 times, most recently
from
0b800ae to
b77d58f
Compare
ktock
force-pushed
the
fuse-manager-tests
branch
3 times, most recently
from
f3591fa to
9233823
Compare
ktock
force-pushed
the
fuse-manager-tests
branch
3 times, most recently
from
0745e35 to
5fdaed7
Compare
AkihiroSuda
reviewed
Jul 16, 2025
docs/overview.md
Outdated
| You can enable the fuse manager by adding the following configuration. | ||
|
|
||
| ```toml | ||
| [fusemanager] |
There was a problem hiding this comment.
nit: s/fusermanager/fuse_manager/ ?
AkihiroSuda
reviewed
Jul 16, 2025
cmd/containerd-stargz-grpc/main.go
Outdated
| FuseManagerAddress string `toml:"fusemanager_address" json:"fusemanager_address"` | ||
|
|
||
| // FuseManagerPath is path to the fusemanager's executable (default: looking for a binary "stargz-fuse-manager") | ||
| FuseManagerPath string `toml:"fusemanager_path" json:"fusemanager_path"` |
There was a problem hiding this comment.
Suggested change
| FuseManagerPath string `toml:"fusemanager_path" json:"fusemanager_path"` | |
| Path string `toml:"path" json:"path"` |
Same for other fields too
ktock
force-pushed
the
fuse-manager-tests
branch
2 times, most recently
from
f127a08 to
3921db5
Compare
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Add JSON tag to configuration fields. This is needed to send configuration to the fuse manager in JSON format. Without this change, some configuration struct passed to the FUSE manager were incorrectly unmarshalled and caused the test failure. Signed-off-by: Kohei Tokunaga <[email protected]>
Add "listen_path" field to the CRI Keychain config to specify a custom socket path for the CRI image service. When the FUSE manager is disabled, this defaults to the containerd-stargz-grpc path (`/run/containerd-stargz-grpc/containerd-stargz-grpc.sock`). When the FUSE manager is enabled with CRI-based authentication, `listen_path` is a mandatory field with some caveats: - This path must be different from the FUSE manager's socket path (`/run/containerd-stargz-grpc/fuse-manager.sock`) because they have different lifecycle. Specifically, the CRI socket is recreted on each reload of the configuration to the FUSE manager. - containerd-stargz-grpc's socket path (`/run/containerd-stargz-grpc/containerd-stargz-grpc.sock`) can't be used as `listen_path` because the CRI socket is served by the FUSE manager process (not containerd-stargz-grpc process). Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
Signed-off-by: Kohei Tokunaga <[email protected]>
ktock
force-pushed
the
fuse-manager-tests
branch
from
3921db5 to
020d347
Compare
AkihiroSuda
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #1892
This PR enables tests for the FUSE manager. Some changes were needed to pass them.