Retry on EINVAL like runc #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be the first issue to backport ;) |
kzys
force-pushed
the
einval
branch
2 times, most recently
from
7444239 to
fb53a45
Compare
dcantah
reviewed
Nov 4, 2022
dcantah
reviewed
Nov 4, 2022
|
needs a rebase to pick up @dcantah's change I guess? |
There is a race condition while adding a brand-new process to cgroups.procs. Like runc, we should retry on EINVAL. We have seen the issue a lot on containerd's Rocky Linux build. containerd/containerd#7532 Signed-off-by: Kazuyoshi Kato <[email protected]>
|
@estesp Yes. Just rebased. |
This was referenced Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition while adding a brand-new process to cgroups.procs. Like runc, we should retry on EINVAL.
We have seen the issue a lot on containerd's Rocky Linux build.
containerd/containerd#7532
Signed-off-by: Kazuyoshi Kato [email protected]