Support cgroup.AddThread in cgroupv2 manager #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoyinnan
force-pushed
the
242/cgroupv2-addThread
branch
2 times, most recently
from
5a3a2c8 to
17367da
Compare
In threaded mode, we need to add thread id to cgroup.threads. This work is to make the cgroupv2 manager support AddThread(). Fixes: containerd#242 Signed-off-by: yaoyinnan <[email protected]>
yaoyinnan
force-pushed
the
242/cgroupv2-addThread
branch
from
17367da to
640c206
Compare
|
@kzys @AkihiroSuda @estesp Please help me to review it. |
kzys
approved these changes
Sep 16, 2022
|
@AkihiroSuda @estesp Please help me to review it. thanks. |
|
@crosbymichael @Zyqsempai @thaJeztah Could you help me to review and merge this PR? thanks. |
dcantah
approved these changes
Sep 20, 2022
dmcgowan
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In threaded mode, we need to add thread id to cgroup.threads. This work is to make the cgroupv2 manager support AddThread().
Fixes: #242
Signed-off-by: yaoyinnan [email protected]