Use custom package for grpc status.proto #76
Merged
+12
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
status-proto-package
branch
from
c6283c0 to
47763d2
Compare
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
commented
Jan 7, 2026
| package google.rpc; | ||
| // This package is for internal use by Connect, and provides no backward | ||
| // compatibility guarantees whatsoever. | ||
| package grpc.status.v1; |
Collaborator
Author
There was a problem hiding this comment.
Actually I remembed that Go has the same behavior as Python, so I went ahead and just copied the file as-is from connect-go
The renamed package is less connectrpc specific, but I figure there's no reason for us to use a different name from it
stefanvanburen
approved these changes
Jan 7, 2026
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
glad there's a workaround, I hadn't seen (or had forgotten 😅) the connect-go one
rjpower
added a commit
to marin-community/marin
that referenced
this pull request
Jan 8, 2026
Use specific git commit (5342eace) from connect-python main branch that fixes the duplicate google.rpc.Status symbol conflict with googleapis-common-protos. The fix renames the package from google.rpc to grpc.status.v1 to avoid conflicts. This resolves the itest (3.12) failure caused by importing both google-cloud-storage and connect-python. Ref: connectrpc/connect-python#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
I had copied this file from connect-es
https://github.com/connectrpc/connect-es/blob/main/packages/connect/src/protocol-grpc/proto/status.proto
but forgot about the python-specific issue when packages clash. This renames the package so it doesn't conflict with the official Google one. The package name doesn't affect us at all so I tried to be precise with it. Since modifying the file anyways, I removed some non-Python bits from it.