-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Low priority since CloudFormation itself fails on tag-only updates to AWS::AppRunner::Service. The panic originates here:
cloudformatious/src/change_set.rs
Lines 666 to 677 in 73cf5ae
| assert!( | |
| // We assume that changes to these attributes would never require recreation. | |
| // NOTE: CloudFormation may report tag changes on AWS::SecretsManager::Secret | |
| // resources as conditionally requiring recreation. We assume this is a bug in | |
| // CloudFormation and ignore it. | |
| matches!( | |
| target.requires_recreation, | |
| None | Some(aws_sdk_cloudformation::model::RequiresRecreation::Never) | |
| ) || resource_type == "AWS::SecretsManager::Secret", | |
| "ResourceTargetDefinition with attribute {:?} with requires_recreation", | |
| attribute | |
| ); |
Note that there's already an exception for AWS::SecretsManager::Secret (introduced in 7e5e35d). For now we could simply add an additional exception for AWS::AppRunner::Service.
Metadata
Metadata
Assignees
Labels
No labels