Skip to content

Conversation

shouples
Copy link
Contributor

@shouples shouples commented Apr 16, 2025

Summary of Changes

Top level PR for any calls returning a Promise that aren't awaited.

This currently shows a lot of failures (100+) during gulp lint:
image

...but we can create some PRs based on this branch to slowly chip away at the different offenders either through adding the void operator, awaiting the promise, or adding the following above an offending line:

// eslint-disable-next-line @typescript-eslint/no-floating-promises

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@shouples shouples added the on hold Blocked until additional functionality is available or more discussions have happened. label Apr 16, 2025
@cprovencher cprovencher added rebase and removed rebase labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Blocked until additional functionality is available or more discussions have happened.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants