fix(tool): modify list schema to use SchemaRegistryClient to be accessible for CP #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and logging - Integrated SchemaRegistryClient for fetching schema subjects and metadata. - Updated argument validation to include a boolean for deleted schemas. - Enhanced logging to provide detailed debug information during schema retrieval. - Improved error handling for fetching schema metadata and versions, ensuring clearer error messages in responses.
…equired environment variables - Eliminated the baseUrl argument from the ListSchemasHandler, simplifying the argument structure. - Updated the getRequiredEnvVars method to include SCHEMA_REGISTRY_ENDPOINT as a necessary environment variable, enhancing configuration management.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ListSchemasHandler to replace the previous path-based client implementation with SchemaRegistryClient, update the argument types, and improve logging and error handling for schema listing operations.
- Replaced wrapAsPathBasedClient with SchemaRegistryClient for schema operations
- Changed the deleted argument from a string to a boolean type with a default value of false
- Improved logging and error handling while restructuring the schema fetching logic
| const versions: number[] = await registry.getAllVersions(subject); | ||
| logger.debug({ subject, versions }, "Fetched all schema versions"); | ||
| result[subject] = []; | ||
| for (const version of versions) { |
There was a problem hiding this comment.
The schema metadata fetching within the for-loop is done sequentially, which could lead to performance bottlenecks. Consider parallelizing these calls using Promise.all to reduce latency.
Suggested change
| for (const version of versions) { | |
| const versionPromises = versions.map(async (version) => { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
ListSchemasHandlerto improve its functionality, logging, and error handling. Key updates include replacing the use ofwrapAsPathBasedClientwith theSchemaRegistryClient, enhancing logging for better debugging, and restructuring the logic to fetch schemas and their metadata.Refactoring and functionality improvements:
wrapAsPathBasedClientwithSchemaRegistryClientfor interacting with the Schema Registry, allowing more granular control over schema operations. [1] [2]deletedargument to use abooleantype with a default value offalsefor better clarity and type safety.Logging enhancements:
logger.debug,logger.info, andlogger.warnstatements to trace the flow of execution, log key operations, and capture errors during schema fetching and filtering.Error handling improvements:
Minor updates:
baseUrlargument to use a function, ensuring it dynamically evaluates the environment variable.