-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
The AWS secret provider has a configuration option of secret.ttl.ms
. However, I don't think it actually does anything.
- The config string is referenced only once in any meaningful way: https://github.com/search?q=repo%3Aconfluentinc%2Fcsid-secrets-providers%20%22secret.ttl.ms%22&type=code
- And that is for the
MIN_TTL_MS_CONFIG
constant:Line 139 in d4a911d
public static final String MIN_TTL_MS_CONFIG = "secret.ttl.ms"; - Which is only referenced to assign it to
minimumSecretTTL
: https://github.com/search?q=repo%3Aconfluentinc%2Fcsid-secrets-providers%20MIN_TTL_MS_CONFIG&type=code - Which appears to be a dead variable: https://github.com/search?q=repo%3Aconfluentinc%2Fcsid-secrets-providers%20minimumSecretTTL&type=code
Seems to me that this secret.ttl.ms
configuration should be deprecated/removed...
Metadata
Metadata
Assignees
Labels
No labels