Add client credentials OAuth support #2426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
rayokota
reviewed
Mar 21, 2025
Member
rayokota
left a comment
rayokota
left a comment
There was a problem hiding this comment.
Thanks @Claimundefine , left some comments
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/IAuthenticationBearerHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
src/Confluent.SchemaRegistry/Rest/Authentication/IAuthenticationBearerHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
airlock-confluentinc
bot
force-pushed
the
DGS-12469_OAuth_support
branch
from
fcab053 to
7589cd0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
rayokota
reviewed
Mar 25, 2025
Member
rayokota
left a comment
rayokota
left a comment
There was a problem hiding this comment.
@Claimundefine , thanks, looking good, left a few nits
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
DGS-12469_OAuth_support
branch
from
ec621c2 to
d406860
Compare
This comment has been minimized.
This comment has been minimized.
rayokota
approved these changes
Mar 26, 2025
Member
rayokota
left a comment
rayokota
left a comment
There was a problem hiding this comment.
Thanks @Claimundefine , left a minor nit, otherwise LGTM
src/Confluent.SchemaRegistry/Rest/Authentication/BearerAuthenticationHeaderValueProvider.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
DGS-12469_OAuth_support
branch
from
eb3d3a7 to
ae966e8
Compare
rayokota
approved these changes
Mar 27, 2025
Member
rayokota
left a comment
rayokota
left a comment
There was a problem hiding this comment.
Thanks @Claimundefine , LGTM
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-dotnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add OAuth support for clients, refactoring the Authentication Provider for BearerAuthentication, as well as an interface for customers to plug their own authentication header providers for custom implementations such as JWT_bearer.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups