DGS-19711 Support Protobuf oneof fields in Data Contract rules #2413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
test/Confluent.SchemaRegistry.Serdes.UnitTests/ProtoSerializeDeserialize.cs:251
- [nitpick] Now that oneof fields are supported, please consider adding tests for scenarios when oneof_int32 is set to ensure both oneof field types are properly handled.
Assert.Equal("oneof-suffix", result.OneofString);
rayokota
commented
Feb 20, 2025
| "CgxQZXJzb24ucHJvdG8SB2V4YW1wbGUiRwoGUGVyc29uEhYKDmZhdm9yaXRl", | ||
| "X2NvbG9yGAEgASgJEhcKD2Zhdm9yaXRlX251bWJlchgCIAEoBRIMCgRuYW1l", | ||
| "GAMgASgJYgZwcm90bzM=")); | ||
| "CgxQZXJzb24ucHJvdG8SB2V4YW1wbGUigwEKBlBlcnNvbhIWCg5mYXZvcml0", |
There was a problem hiding this comment.
This file is generated and can be ignored.
Claimundefine
approved these changes
Feb 20, 2025
Analysis Details0 Issues
Coverage and Duplications
Project ID: confluent-kafka-dotnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support Protobuf oneof fields in Data Contract rules.
The file Person.cs is generated and can be ignored.
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups