Skip to content

DGS-18985 Fix JSON Schema ref handling #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2024
Merged

DGS-18985 Fix JSON Schema ref handling #2339

merged 3 commits into from
Nov 7, 2024

Conversation

rayokota
Copy link
Member

@rayokota rayokota commented Nov 6, 2024 •
edited
Loading

Fix JSON Schema ref handling. Before the code relied on the reference name also being the $id for the referenced schema.

@rayokota rayokota requested review from a team as code owners November 6, 2024 19:49
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

kcorman0
kcorman0 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@kcorman0 kcorman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@rayokota rayokota merged commit c28ff3f into master Nov 7, 2024
2 checks passed
@rayokota rayokota deleted the fix-json-refs branch November 7, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcorman0 kcorman0 kcorman0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayokota @kcorman0