Fix IConsumer breaking change #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A method was added to the IConsumer interface by #2027 that resulted in a breaking change in the 2.1 release. This replaces the interface method and the implementation on Consumer with an extension method on IConsumer to ensure that existing implementations of IConsumer remain unbroken and have the same functionality as the default Consumer implementation.
emasab
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a breaking change in the IConsumer interface introduced by #2027 by replacing the interface method and the implementation on Consumer with an extension method on IConsumer. This ensures that existing implementations of IConsumer remain unbroken and have the same functionality as the default Consumer implementation.
Referenced from #2067.
Testing
Integration tests